OpenBIOS September 2010

openbios@openbios.org

22 participants
46 discussions

[PATCH 1/2] CIF: Emit debug linebreak when method fails
by Andreas Färber 29 Sep '10

29 Sep '10

When DEBUG_CIF is defined, a serial message of the form "method(...) = " is emitted by dump_service(). After successful execution the return value and a linebreak are emitted by dump_return(). If however the method fails, nothing is emitted, so that subsequent method calls end up in place of the return value. Observed for getproplen with AIX. Emit an error indication and a linebreak when DEBUG_CIF is defined. Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> --- libopenbios/client.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libopenbios/client.c b/libopenbios/client.c index 9cea0e7..4c43a99 100644 --- a/libopenbios/client.c +++ b/libopenbios/client.c @@ -306,6 +306,10 @@ of_client_interface( int *params ) if( val == -1 ) printk("Unimplemented service %s ([%ld] -- [%ld])\n", pb->service, pb->nargs, pb->nret ); +#ifdef DEBUG_CIF + else + printk("ERROR!\n"); +#endif return -1; } -- 1.7.3

3 4

[commit] r869 - trunk/openbios-devel/libopenbios
by repository service 29 Sep '10

29 Sep '10

Author: mcayland Date: Wed Sep 29 18:28:28 2010 New Revision: 869 URL: http://tracker.coreboot.org/trac/openbios/changeset/869 Log: Prettify the whitespace placement. Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/libopenbios/client.c Modified: trunk/openbios-devel/libopenbios/client.c ============================================================================== --- trunk/openbios-devel/libopenbios/client.c Wed Sep 29 18:27:42 2010 (r868) +++ trunk/openbios-devel/libopenbios/client.c Wed Sep 29 18:28:28 2010 (r869) @@ -220,7 +220,7 @@ } else { printk("of_client_interface return:"); for (i = 0; i < pb->nret; i++) { - printk("%lx ", pb->args[pb->nargs + i]); + printk(" %lx", pb->args[pb->nargs + i]); } printk("\n"); }

1 0

[commit] r867 - trunk/openbios-devel/packages
by repository service 28 Sep '10

28 Sep '10

Author: blueswirl Date: Tue Sep 28 20:59:47 2010 New Revision: 867 URL: http://tracker.coreboot.org/trac/openbios/changeset/867 Log: disk-label: fix memory leakages Avoid a strdup() call. Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/packages/disk-label.c Modified: trunk/openbios-devel/packages/disk-label.c ============================================================================== --- trunk/openbios-devel/packages/disk-label.c Tue Sep 28 20:59:45 2010 (r866) +++ trunk/openbios-devel/packages/disk-label.c Tue Sep 28 20:59:47 2010 (r867) @@ -64,9 +64,6 @@ cell status; path = my_args_copy(); - if (!path) { - path = strdup(""); - } DPRINTF("dlabel-open '%s'\n", path ); @@ -122,14 +119,14 @@ DPRINTF("Located filesystem with ph " FMT_ucellx "\n", ph); DPRINTF("path: %s length: %d\n", path, strlen(path)); - if (strlen(path)) { + if (path && strlen(path)) { DPRINTF("INTERPOSE!\n"); push_str( path ); PUSH_ph( ph ); fword("interpose"); } - } else if (*path && strcmp(path, "%BOOT") != 0) { + } else if (path && strcmp(path, "%BOOT") != 0) { goto out; }

1 0

[commit] r866 - trunk/openbios-devel/packages
by repository service 28 Sep '10

28 Sep '10

Author: blueswirl Date: Tue Sep 28 20:59:45 2010 New Revision: 866 URL: http://tracker.coreboot.org/trac/openbios/changeset/866 Log: sun-parts: fix memory leakages Free the string returned by my_args_copy() also in error cases. Adjust string parsing to avoid strdup() calls. Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/packages/sun-parts.c Modified: trunk/openbios-devel/packages/sun-parts.c ============================================================================== --- trunk/openbios-devel/packages/sun-parts.c Tue Sep 28 20:59:43 2010 (r865) +++ trunk/openbios-devel/packages/sun-parts.c Tue Sep 28 20:59:45 2010 (r866) @@ -92,8 +92,8 @@ sunparts_open( sunparts_info_t *di ) { char *str = my_args_copy(); - char *argstr = strdup(""); - char *parstr = strdup(""); + char *argstr = NULL; + char *parstr = NULL; int parnum = -1; unsigned char buf[512]; struct sun_disklabel *p; @@ -140,7 +140,7 @@ } /* Convert the id to a partition number */ - if (strlen(parstr)) { + if (parstr && strlen(parstr)) { if (parstr[0] >= 'a' && parstr[0] < ('a' + 8)) parnum = parstr[0] - 'a'; else @@ -156,12 +156,15 @@ di->seek_xt = find_parent_method("seek"); SEEK( 0 ); - if( READ(buf, 512) != 512 ) + if (READ(buf, 512) != 512) { + free(str); RET(0); + } /* Check Magic */ if (!has_sun_part_magic(buf)) { DPRINTF("Sun partition magic not found.\n"); + free(str); RET(0); } @@ -190,6 +193,7 @@ size = (long long)__be32_to_cpu(p->partitions[parnum].num_sectors) * bs; if (size == 0) { DPRINTF("Partition size is 0, exiting\n"); + free(str); RET(0); } di->size_hi = size >> BITS; @@ -213,7 +217,7 @@ /* If we have been asked to open a particular file, interpose the filesystem package with the passed filename as an argument */ - if (strlen(argstr)) { + if (argstr && strlen(argstr)) { push_str( argstr ); PUSH_ph( ph ); fword("interpose"); @@ -228,7 +232,7 @@ feval("find-package"); ph = POP_ph(); - if (ph) { + if (argstr && ph) { ph = POP_ph(); push_str(argstr); PUSH_ph(ph);

1 0

[commit] r865 - trunk/openbios-devel/fs/iso9660
by repository service 28 Sep '10

28 Sep '10

Author: blueswirl Date: Tue Sep 28 20:59:43 2010 New Revision: 865 URL: http://tracker.coreboot.org/trac/openbios/changeset/865 Log: iso9660: Make name comparison case-insensitive Make seek_name() compare the path component in a case-insensitive way. Should fix an issue reported by Mark. Cc: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Cc: Laurent Vivier <laurent(a)vivier.eu> Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/fs/iso9660/iso9660_opendir.c Modified: trunk/openbios-devel/fs/iso9660/iso9660_opendir.c ============================================================================== --- trunk/openbios-devel/fs/iso9660/iso9660_opendir.c Tue Sep 28 20:59:41 2010 (r864) +++ trunk/openbios-devel/fs/iso9660/iso9660_opendir.c Tue Sep 28 20:59:43 2010 (r865) @@ -55,7 +55,7 @@ while ((idr = iso9660_readdir(dir)) != NULL) { iso9660_name(volume, idr, name_buf); - if (strcmp(name, name_buf) == 0) + if (strcasecmp(name, name_buf) == 0) { result = idr_new(idr); iso9660_closedir(dir);

1 0

[commit] r864 - trunk/openbios-devel/fs/iso9660
by repository service 28 Sep '10

28 Sep '10

Author: blueswirl Date: Tue Sep 28 20:59:41 2010 New Revision: 864 URL: http://tracker.coreboot.org/trac/openbios/changeset/864 Log: iso9660: Fix Forth return value for iso9660_files_open() There's a mixup of 0 and -1. Don't return failure if iso9660_open() succeeded. Don't return success in case iso9660_open() or iso9660_mount() failed. This resolves both a hang when trying to boot cd:,\\:tbxi and failure to boot either cd:,\ppc\bootinfo.txt or cd:,\ppc\chrp\bootfile.exe despite present on the AIX 6.1 disk. Cc: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/fs/iso9660/iso9660_fs.c Modified: trunk/openbios-devel/fs/iso9660/iso9660_fs.c ============================================================================== --- trunk/openbios-devel/fs/iso9660/iso9660_fs.c Sat Sep 25 19:07:10 2010 (r863) +++ trunk/openbios-devel/fs/iso9660/iso9660_fs.c Tue Sep 28 20:59:41 2010 (r864) @@ -49,7 +49,7 @@ if ( mi->volume == NULL ) { free( path ); close_io( fd ); - RET( -1 ); + RET( 0 ); } mi->common->dir = iso9660_opendir( mi->volume, path ); @@ -59,11 +59,11 @@ iso9660_umount( mi->volume ); close_io( fd ); free( path ); - RET( -1 ); + RET( 0 ); } mi->common->type = FILE; free( path ); - RET( 0 ); + RET( -1 ); } mi->common->type = DIR; free( path );

1 0

Re: [OpenBIOS] Learning Forth
by Programmingkid 27 Sep '10

27 Sep '10

On Sep 27, 2010, at 4:57 AM, openbios-request(a)openbios.org wrote: > On Sep 26, 2010, at 3:24 AM, openbios-request(a)openbios.org wrote: > >> Message: 8 >> Date: Sun, 26 Sep 2010 07:23:31 +0000 >> From: Blue Swirl <blauwirbel(a)gmail.com> >> To: The OpenBIOS Mailinglist <openbios(a)openbios.org> >> Subject: Re: [OpenBIOS] Learning Forth >> Message-ID: >> <AANLkTinpVXx_YeYy16TiPhuscytObcRmx62n-FdDJoUR(a)mail.gmail.com> >> Content-Type: text/plain; charset=UTF-8 >> >> On Sat, Sep 25, 2010 at 11:00 PM, Programmingkid >> <programmingkidx(a)gmail.com> wrote: >>> I am thinking about buying a book on learning Forth. Would anyone have a suggestion? >> >> I got my Forth skills by reading "Starting Forth" by Leo Brodie. It is >> available online: >> http://www.forth.com/starting-forth/ > > > Thank you for the suggestion. Just curious, has anyone read Forth Programmer's Handbook 3rd edition? If so, would you recommend the book?

1 0

a boring question, is that forth quick?
by kim.jin 27 Sep '10

27 Sep '10

Hi, Generally speaking, is that Forth quicker than C? I hope to know, if we write OpenBIOS by C, is it quicker? BTW, which program language does used to write FCode evaluator? Best Regards! Kim King 2010-09-27

2 1

Re: [OpenBIOS] Learning Forth
by Programmingkid 27 Sep '10

27 Sep '10

On Sep 26, 2010, at 3:24 AM, openbios-request(a)openbios.org wrote: > Message: 8 > Date: Sun, 26 Sep 2010 07:23:31 +0000 > From: Blue Swirl <blauwirbel(a)gmail.com> > To: The OpenBIOS Mailinglist <openbios(a)openbios.org> > Subject: Re: [OpenBIOS] Learning Forth > Message-ID: > <AANLkTinpVXx_YeYy16TiPhuscytObcRmx62n-FdDJoUR(a)mail.gmail.com> > Content-Type: text/plain; charset=UTF-8 > > On Sat, Sep 25, 2010 at 11:00 PM, Programmingkid > <programmingkidx(a)gmail.com> wrote: >> I am thinking about buying a book on learning Forth. Would anyone have a suggestion? > > I got my Forth skills by reading "Starting Forth" by Leo Brodie. It is > available online: > http://www.forth.com/starting-forth/ Thank you for the suggestion.

1 0

Learning Forth
by Programmingkid 26 Sep '10

26 Sep '10

I am thinking about buying a book on learning Forth. Would anyone have a suggestion?

2 1