OpenBIOS June 2010

openbios@openbios.org

14 participants
30 discussions

[commit] r800 - trunk/openbios-devel/libopenbios
by repository service 27 Jun '10

27 Jun '10

Author: mcayland Date: Sun Jun 27 15:14:03 2010 New Revision: 800 URL: http://tracker.coreboot.org/trac/openbios/changeset/800 Log: Move Forth loader into the new C load implementation. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/libopenbios/load.c Modified: trunk/openbios-devel/libopenbios/load.c ============================================================================== --- trunk/openbios-devel/libopenbios/load.c Sun Jun 27 15:06:38 2010 (r799) +++ trunk/openbios-devel/libopenbios/load.c Sun Jun 27 15:14:03 2010 (r800) @@ -20,7 +20,7 @@ #include "libopenbios/load.h" #include "libopenbios/fcode_load.h" - +#include "libopenbios/forth_load.h" void load(ihandle_t dev) { @@ -30,4 +30,8 @@ fcode_load(dev); #endif +#ifdef CONFIG_LOADER_FORTH + forth_load(dev); +#endif + }

1 0

[commit] r799 - in trunk/openbios-devel: arch/sparc32 arch/sparc64 arch/x86 include/libopenbios libopenbios
by repository service 27 Jun '10

27 Jun '10

Author: mcayland Date: Sun Jun 27 15:06:38 2010 New Revision: 799 URL: http://tracker.coreboot.org/trac/openbios/changeset/799 Log: Switch Forth loader over to using an ihandle rather than a direct path reference. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/arch/sparc32/boot.c trunk/openbios-devel/arch/sparc64/boot.c trunk/openbios-devel/arch/x86/boot.c trunk/openbios-devel/include/libopenbios/forth_load.h trunk/openbios-devel/libopenbios/forth_load.c Modified: trunk/openbios-devel/arch/sparc32/boot.c ============================================================================== --- trunk/openbios-devel/arch/sparc32/boot.c Fri Jun 25 22:42:00 2010 (r798) +++ trunk/openbios-devel/arch/sparc32/boot.c Sun Jun 27 15:06:38 2010 (r799) @@ -72,7 +72,7 @@ #ifdef CONFIG_LOADER_FORTH /* Forth loader */ - forth_load(path); + forth_load(dev); feval("state-valid @"); valid = POP(); if (valid) Modified: trunk/openbios-devel/arch/sparc64/boot.c ============================================================================== --- trunk/openbios-devel/arch/sparc64/boot.c Fri Jun 25 22:42:00 2010 (r798) +++ trunk/openbios-devel/arch/sparc64/boot.c Sun Jun 27 15:06:38 2010 (r799) @@ -64,7 +64,7 @@ #ifdef CONFIG_LOADER_FORTH /* Forth loader */ - forth_load(path); + forth_load(dev); feval("state-valid @"); valid = POP(); if (valid) Modified: trunk/openbios-devel/arch/x86/boot.c ============================================================================== --- trunk/openbios-devel/arch/x86/boot.c Fri Jun 25 22:42:00 2010 (r798) +++ trunk/openbios-devel/arch/x86/boot.c Sun Jun 27 15:06:38 2010 (r799) @@ -61,7 +61,7 @@ #ifdef CONFIG_LOADER_FORTH /* Forth loader */ - forth_load(path); + forth_load(dev); feval("state-valid @"); valid = POP(); if (valid) Modified: trunk/openbios-devel/include/libopenbios/forth_load.h ============================================================================== --- trunk/openbios-devel/include/libopenbios/forth_load.h Fri Jun 25 22:42:00 2010 (r798) +++ trunk/openbios-devel/include/libopenbios/forth_load.h Sun Jun 27 15:06:38 2010 (r799) @@ -18,7 +18,7 @@ #define _H_FORTHLOAD extern int is_forth(char *forth); -extern int forth_load(const char *filename); +extern int forth_load(ihandle_t dev); extern void forth_init_program(void); #endif /* _H_FORTHLOAD */ Modified: trunk/openbios-devel/libopenbios/forth_load.c ============================================================================== --- trunk/openbios-devel/libopenbios/forth_load.c Fri Jun 25 22:42:00 2010 (r798) +++ trunk/openbios-devel/libopenbios/forth_load.c Sun Jun 27 15:06:38 2010 (r799) @@ -23,7 +23,7 @@ return (forth[0] == '\\' && forth[1] == ' '); } -int forth_load(const char *filename) +int forth_load(ihandle_t dev) { char magic[2]; unsigned long forthsize; @@ -32,7 +32,7 @@ /* Mark the saved-program-state as invalid */ feval("0 state-valid !"); - fd = open_io(filename); + fd = open_ih(dev); if (!fd) goto out;

1 0

[commit] r798 - in trunk/openbios-devel: arch/sparc32 arch/sparc64 arch/x86 forth/admin include/libopenbios libopenbios packages
by repository service 25 Jun '10

25 Jun '10

Author: mcayland Date: Fri Jun 25 22:42:00 2010 New Revision: 798 URL: http://tracker.coreboot.org/trac/openbios/changeset/798 Log: Implement a basic C loader function in load.c that tries to load each supported executable file format. Now that the ihandle hierarchy is correct, we can simply pass an ihandle into the loader and it will work correctly regardless of whether it is being invoked on an entire disk, partition or individual file. In order to test the new code, start by switching the Fcode loader over to the new infrastructure for testing on SPARC64. Note this patch also contains a correction to load-base on SPARC which was being set to a value other than 0x4000 which is the documented default. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Added: trunk/openbios-devel/include/libopenbios/load.h trunk/openbios-devel/libopenbios/load.c Modified: trunk/openbios-devel/arch/sparc32/boot.c trunk/openbios-devel/arch/sparc64/boot.c trunk/openbios-devel/arch/x86/boot.c trunk/openbios-devel/forth/admin/nvram.fs trunk/openbios-devel/include/libopenbios/fcode_load.h trunk/openbios-devel/libopenbios/build.xml trunk/openbios-devel/libopenbios/fcode_load.c trunk/openbios-devel/packages/disk-label.c trunk/openbios-devel/packages/mac-parts.c trunk/openbios-devel/packages/pc-parts.c trunk/openbios-devel/packages/sun-parts.c Modified: trunk/openbios-devel/arch/sparc32/boot.c ============================================================================== --- trunk/openbios-devel/arch/sparc32/boot.c Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/arch/sparc32/boot.c Fri Jun 25 22:42:00 2010 (r798) @@ -30,12 +30,16 @@ { void *boot_notes = NULL; ucell valid; + ihandle_t dev; push_str(path); fword("pathres-resolve-aliases"); bootpath = pop_fstr_copy(); printk("Trying %s (%s)\n", path, bootpath); + /* Open device used by this path */ + dev = open_dev(path); + #ifdef CONFIG_LOADER_ELF /* ELF Boot loader */ elf_load(&sys_info, path, param, &boot_notes); @@ -59,7 +63,7 @@ #ifdef CONFIG_LOADER_FCODE /* Fcode loader */ - fcode_load(path); + fcode_load(dev); feval("state-valid @"); valid = POP(); if (valid) @@ -75,6 +79,8 @@ goto start_image; #endif + close_dev(dev); + return 0; Modified: trunk/openbios-devel/arch/sparc64/boot.c ============================================================================== --- trunk/openbios-devel/arch/sparc64/boot.c Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/arch/sparc64/boot.c Fri Jun 25 22:42:00 2010 (r798) @@ -27,6 +27,10 @@ static int try_path(const char *path, char *param) { ucell valid; + ihandle_t dev; + + /* Open device used by this path */ + dev = open_dev(path); #ifdef CONFIG_LOADER_ELF /* ELF Boot loader */ @@ -51,7 +55,7 @@ #ifdef CONFIG_LOADER_FCODE /* Fcode loader */ - fcode_load(path); + fcode_load(dev); feval("state-valid @"); valid = POP(); if (valid) @@ -67,6 +71,8 @@ goto start_image; #endif + close_dev(dev); + return 0; Modified: trunk/openbios-devel/arch/x86/boot.c ============================================================================== --- trunk/openbios-devel/arch/x86/boot.c Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/arch/x86/boot.c Fri Jun 25 22:42:00 2010 (r798) @@ -24,6 +24,10 @@ static int try_path(const char *path, char *param) { ucell valid; + ihandle_t dev; + + /* Open device used by this path */ + dev = open_dev(path); #ifdef CONFIG_LOADER_ELF /* ELF Boot loader */ @@ -48,7 +52,7 @@ #ifdef CONFIG_LOADER_FCODE /* Fcode loader */ - fcode_load(path); + fcode_load(dev); feval("state-valid @"); valid = POP(); if (valid) @@ -64,6 +68,8 @@ goto start_image; #endif + close_dev(dev); + return 0; Modified: trunk/openbios-devel/forth/admin/nvram.fs ============================================================================== --- trunk/openbios-devel/forth/admin/nvram.fs Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/forth/admin/nvram.fs Fri Jun 25 22:42:00 2010 (r798) @@ -358,7 +358,7 @@ [IFDEF] CONFIG_SPARC64 \ ---- SPARC64 ---- -s" 4000000" s" load-base" int-config +s" 4000" s" load-base" int-config s" false" s" little-endian?" bool-config [THEN] Modified: trunk/openbios-devel/include/libopenbios/fcode_load.h ============================================================================== --- trunk/openbios-devel/include/libopenbios/fcode_load.h Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/include/libopenbios/fcode_load.h Fri Jun 25 22:42:00 2010 (r798) @@ -18,7 +18,7 @@ #define _H_FCODELOAD extern int is_fcode(unsigned char *fcode); -extern int fcode_load(const char *filename); +extern int fcode_load(ihandle_t dev); extern void fcode_init_program(void); #endif /* _H_FCODELOAD */ Added: trunk/openbios-devel/include/libopenbios/load.h ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/openbios-devel/include/libopenbios/load.h Fri Jun 25 22:42:00 2010 (r798) @@ -0,0 +1,22 @@ +/* + * Creation Date: <2010/06/25 20:00:00 mcayland> + * Time-stamp: <2010/06/25 20:00:00 mcayland> + * + * <load.h> + * + * C implementation of load + * + * Copyright (C) 2010 Mark Cave-Ayland (mark.cave-ayland(a)siriusit.co.uk) + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 + * + */ + +#ifndef _H_LOAD +#define _H_LOAD + +extern void load(ihandle_t dev); + +#endif /* _H_LOAD */ Modified: trunk/openbios-devel/libopenbios/build.xml ============================================================================== --- trunk/openbios-devel/libopenbios/build.xml Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/libopenbios/build.xml Fri Jun 25 22:42:00 2010 (r798) @@ -15,6 +15,7 @@ <object source="init.c"/> <object source="initprogram.c"/> <object source="ipchecksum.c"/> + <object source="load.c"/> <object source="linuxbios_info.c" condition="LINUXBIOS"/> <object source="ofmem_common.c" condition="OFMEM"/> <object source="xcoff_load.c" condition="LOADER_XCOFF"/> Modified: trunk/openbios-devel/libopenbios/fcode_load.c ============================================================================== --- trunk/openbios-devel/libopenbios/fcode_load.c Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/libopenbios/fcode_load.c Fri Jun 25 22:42:00 2010 (r798) @@ -24,7 +24,7 @@ } int -fcode_load(const char *filename) +fcode_load(ihandle_t dev) { int retval = -1; uint8_t fcode_header[8]; @@ -34,7 +34,7 @@ /* Mark the saved-program-state as invalid */ feval("0 state-valid !"); - fd = open_io(filename); + fd = open_ih(dev); if (!fd) goto out; @@ -42,7 +42,7 @@ seek_io(fd, offset); if (read_io(fd, &fcode_header, sizeof(fcode_header)) != sizeof(fcode_header)) { - debug("Can't read FCode header from file %s\n", filename); + debug("Can't read FCode header from ihandle " FMT_ucellx "\n", dev); retval = LOADER_NOT_SUPPORT; goto out; } @@ -59,11 +59,12 @@ size = (fcode_header[4] << 24) | (fcode_header[5] << 16) | (fcode_header[6] << 8) | fcode_header[7]; - start = 0x4000; + fword("load-base"); + start = POP(); - printf("Loading FCode image...\n"); + printf("\nLoading FCode image...\n"); - seek_io(fd, offset + sizeof(fcode_header)); + seek_io(fd, offset); if ((size_t)read_io(fd, (void *)start, size) != size) { printf("Can't read file (size 0x%lx)\n", size); @@ -92,6 +93,7 @@ { /* If the payload is Fcode then we execute it immediately */ ucell address; + uint8_t fcode_header[8]; fword("load-base"); address = POP(); @@ -101,7 +103,7 @@ return; } - PUSH(address); + PUSH(address + sizeof(fcode_header)); PUSH(1); fword("byte-load"); } Added: trunk/openbios-devel/libopenbios/load.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/openbios-devel/libopenbios/load.c Fri Jun 25 22:42:00 2010 (r798) @@ -0,0 +1,33 @@ +/* + * Creation Date: <2010/06/25 20:00:00 mcayland> + * Time-stamp: <2010/06/25 20:00:00 mcayland> + * + * <load.c> + * + * C implementation of load + * + * Copyright (C) 2010 Mark Cave-Ayland (mark.cave-ayland(a)siriusit.co.uk) + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 + * + */ + +#include "config.h" +#include "kernel/kernel.h" +#include "libopenbios/bindings.h" +#include "libopenbios/load.h" + +#include "libopenbios/fcode_load.h" + + +void load(ihandle_t dev) +{ + /* Invoke the loaders on the specified device */ + +#ifdef CONFIG_LOADER_FCODE + fcode_load(dev); +#endif + +} Modified: trunk/openbios-devel/packages/disk-label.c ============================================================================== --- trunk/openbios-devel/packages/disk-label.c Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/packages/disk-label.c Fri Jun 25 22:42:00 2010 (r798) @@ -177,7 +177,7 @@ xt = find_ih_method("load", di->part_ih); if (!xt) { - forth_printf("load currently not implemented for /packages/disk-label\n"); + forth_printf("load currently not implemented for ihandle " FMT_ucellx "\n", di->part_ih); PUSH(0); return; } Modified: trunk/openbios-devel/packages/mac-parts.c ============================================================================== --- trunk/openbios-devel/packages/mac-parts.c Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/packages/mac-parts.c Fri Jun 25 22:42:00 2010 (r798) @@ -16,6 +16,7 @@ #include "config.h" #include "libopenbios/bindings.h" +#include "libopenbios/load.h" #include "mac-parts.h" #include "libc/byteorder.h" #include "libc/vsprintf.h" @@ -328,8 +329,8 @@ static void macparts_load( __attribute__((unused))macparts_info_t *di ) { - forth_printf("load currently not implemented for /packages/mac-parts\n"); - PUSH(0); + /* Invoke the loader */ + load(my_self()); } NODE_METHODS( macparts ) = { Modified: trunk/openbios-devel/packages/pc-parts.c ============================================================================== --- trunk/openbios-devel/packages/pc-parts.c Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/packages/pc-parts.c Fri Jun 25 22:42:00 2010 (r798) @@ -14,6 +14,7 @@ #include "config.h" #include "libopenbios/bindings.h" +#include "libopenbios/load.h" #include "libc/byteorder.h" #include "libc/vsprintf.h" #include "packages.h" @@ -352,8 +353,8 @@ static void pcparts_load( __attribute__((unused))pcparts_info_t *di ) { - forth_printf("load currently not implemented for /packages/pc-parts\n"); - PUSH(0); + /* Invoke the loader */ + load(my_self()); } Modified: trunk/openbios-devel/packages/sun-parts.c ============================================================================== --- trunk/openbios-devel/packages/sun-parts.c Wed Jun 23 23:02:12 2010 (r797) +++ trunk/openbios-devel/packages/sun-parts.c Fri Jun 25 22:42:00 2010 (r798) @@ -14,6 +14,7 @@ #include "config.h" #include "libopenbios/bindings.h" +#include "libopenbios/load.h" #include "libc/byteorder.h" #include "libc/vsprintf.h" #include "packages.h" @@ -284,8 +285,8 @@ static void sunparts_load( __attribute__((unused))sunparts_info_t *di ) { - forth_printf("load currently not implemented for /packages/sun-parts\n"); - PUSH(0); + /* Invoke the loader */ + load(my_self()); }

1 0

[commit] r797 - trunk/openbios-devel/fs/ext2
by repository service 23 Jun '10

23 Jun '10

Author: mcayland Date: Wed Jun 23 23:02:12 2010 New Revision: 797 URL: http://tracker.coreboot.org/trac/openbios/changeset/797 Log: ext2 magic is stored in little-endian format, not big-endian format. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/fs/ext2/ext2_utils.c Modified: trunk/openbios-devel/fs/ext2/ext2_utils.c ============================================================================== --- trunk/openbios-devel/fs/ext2/ext2_utils.c Wed Jun 23 22:41:34 2010 (r796) +++ trunk/openbios-devel/fs/ext2/ext2_utils.c Wed Jun 23 23:02:12 2010 (r797) @@ -20,7 +20,7 @@ seek_io(fd, 2 * 512 + offset); read_io(fd, super, sizeof (*super)); - if (__be16_to_cpu(super->s_magic) != EXT2_SUPER_MAGIC) { + if (__le16_to_cpu(super->s_magic) != EXT2_SUPER_MAGIC) { free(super); return 0; }

1 0

[commit] r796 - in trunk/openbios-devel: fs/ext2 fs/hfs fs/hfsplus fs/iso9660 include/fs packages
by repository service 23 Jun '10

23 Jun '10

Author: mcayland Date: Wed Jun 23 22:41:34 2010 New Revision: 796 URL: http://tracker.coreboot.org/trac/openbios/changeset/796 Log: Fix up non-grub iso9660 filesystem, plus correct a thinko where the sense of the existing hfs/ext2 probe functions was inverted by default. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/fs/ext2/ext2_fs.c trunk/openbios-devel/fs/hfs/hfs_fs.c trunk/openbios-devel/fs/hfsplus/hfsp_fs.c trunk/openbios-devel/fs/iso9660/iso9660_fs.c trunk/openbios-devel/fs/iso9660/iso9660_mount.c trunk/openbios-devel/fs/iso9660/libiso9660.h trunk/openbios-devel/include/fs/fs.h trunk/openbios-devel/packages/misc-files.c Modified: trunk/openbios-devel/fs/ext2/ext2_fs.c ============================================================================== --- trunk/openbios-devel/fs/ext2/ext2_fs.c Tue Jun 15 21:59:47 2010 (r795) +++ trunk/openbios-devel/fs/ext2/ext2_fs.c Wed Jun 23 22:41:34 2010 (r796) @@ -205,7 +205,7 @@ int fs_ext2_probe(int fd, llong offs) { if (ext2_probe(fd, offs)) - return -1; + return 0; - return 0; + return -1; } Modified: trunk/openbios-devel/fs/hfs/hfs_fs.c ============================================================================== --- trunk/openbios-devel/fs/hfs/hfs_fs.c Tue Jun 15 21:59:47 2010 (r795) +++ trunk/openbios-devel/fs/hfs/hfs_fs.c Wed Jun 23 22:41:34 2010 (r796) @@ -463,7 +463,7 @@ fs_hfs_probe( int fd, llong offs ) { if (hfs_probe(fd, offs)) - return -1; + return 0; - return 0; + return -1; } Modified: trunk/openbios-devel/fs/hfsplus/hfsp_fs.c ============================================================================== --- trunk/openbios-devel/fs/hfsplus/hfsp_fs.c Tue Jun 15 21:59:47 2010 (r795) +++ trunk/openbios-devel/fs/hfsplus/hfsp_fs.c Wed Jun 23 22:41:34 2010 (r796) @@ -402,7 +402,7 @@ fs_hfsp_probe(int fd, llong offs) { if (volume_probe(fd, offs)) - return -1; + return 0; - return 0; + return -1; } Modified: trunk/openbios-devel/fs/iso9660/iso9660_fs.c ============================================================================== --- trunk/openbios-devel/fs/iso9660/iso9660_fs.c Tue Jun 15 21:59:47 2010 (r795) +++ trunk/openbios-devel/fs/iso9660/iso9660_fs.c Wed Jun 23 22:41:34 2010 (r796) @@ -152,6 +152,15 @@ .get_fstype = get_fstype, }; +int +fs_iso9660_probe( int fd, llong offs ) +{ + if (iso9660_probe(fd, offs)) + return 0; + + return -1; +} + int fs_iso9660_open(int fd, fs_ops_t *fs) { iso9660_VOLUME *volume; Modified: trunk/openbios-devel/fs/iso9660/iso9660_mount.c ============================================================================== --- trunk/openbios-devel/fs/iso9660/iso9660_mount.c Tue Jun 15 21:59:47 2010 (r795) +++ trunk/openbios-devel/fs/iso9660/iso9660_mount.c Wed Jun 23 22:41:34 2010 (r796) @@ -189,6 +189,22 @@ return 0; } +int iso9660_probe(int fd, llong offset) +{ + struct iso_primary_descriptor ipd; + + seek_io(fd, 16 * ISOFS_BLOCK_SIZE + offset); + read_io(fd, &ipd, sizeof (ipd)); + + if ((ipd.type[0] != ISO_VD_PRIMARY) || + (strncmp(ipd.id, ISO_STANDARD_ID, sizeof (ipd.id)) != 0) || + (ipd.version[0] != 1)) { + return 0; + } + + return -1; +} + struct iso_directory_record *iso9660_get_root_node(iso9660_VOLUME* volume) { return (struct iso_directory_record *)volume->descriptor->root_directory_record; Modified: trunk/openbios-devel/fs/iso9660/libiso9660.h ============================================================================== --- trunk/openbios-devel/fs/iso9660/libiso9660.h Tue Jun 15 21:59:47 2010 (r795) +++ trunk/openbios-devel/fs/iso9660/libiso9660.h Wed Jun 23 22:41:34 2010 (r796) @@ -14,6 +14,7 @@ extern iso9660_VOLUME* iso9660_mount(int fd); extern int iso9660_umount(iso9660_VOLUME *volume); +extern int iso9660_probe(int fd, llong offs); extern iso9660_DIR* iso9660_opendir(iso9660_VOLUME *, const char *name); extern iso9660_FILE* iso9660_open(iso9660_VOLUME *, const char *pathname); extern int iso9660_closedir(iso9660_DIR *dir); Modified: trunk/openbios-devel/include/fs/fs.h ============================================================================== --- trunk/openbios-devel/include/fs/fs.h Tue Jun 15 21:59:47 2010 (r795) +++ trunk/openbios-devel/include/fs/fs.h Wed Jun 23 22:41:34 2010 (r796) @@ -69,8 +69,10 @@ #ifdef CONFIG_ISO9660 extern int fs_iso9660_open( int fd, fs_ops_t *fs ); +extern int fs_iso9660_probe( int fd, llong offs ); #else static inline int fs_iso9660_open( int fd, fs_ops_t *fs ) { return -1; } +static inline int fs_iso9660_probe( int fd, llong offs ) { return -1; } #endif #ifdef CONFIG_EXT2 Modified: trunk/openbios-devel/packages/misc-files.c ============================================================================== --- trunk/openbios-devel/packages/misc-files.c Tue Jun 15 21:59:47 2010 (r795) +++ trunk/openbios-devel/packages/misc-files.c Wed Jun 23 22:41:34 2010 (r796) @@ -359,12 +359,12 @@ err = fs_hfs_probe(fd, offs); DPRINTF("--- HFS returned %d\n", err); } -/* + if( err ) { - err = fs_iso9660_open(fd, fs); + err = fs_iso9660_probe(fd, offs); DPRINTF("--- ISO9660 returned %d\n", err); } -*/ + if( err ) { err = fs_ext2_probe(fd, offs); DPRINTF("--- ext2 returned %d\n", err);

1 0

[commit] r793 - in trunk/openbios-devel/fs: hfs hfsplus
by repository service 17 Jun '10

17 Jun '10

Author: blueswirl Date: Thu Jun 10 20:35:25 2010 New Revision: 793 URL: http://tracker.coreboot.org/trac/openbios/changeset/793 Log: Fix PPC target build Fix errors like this: ../fs/hfs/volume.c:612:2: error: no newline at end of file Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/fs/hfs/hfs_fs.c trunk/openbios-devel/fs/hfs/volume.c trunk/openbios-devel/fs/hfsplus/hfsp_fs.c trunk/openbios-devel/fs/hfsplus/volume.c Modified: trunk/openbios-devel/fs/hfs/hfs_fs.c ============================================================================== --- trunk/openbios-devel/fs/hfs/hfs_fs.c Thu Jun 10 00:30:32 2010 (r792) +++ trunk/openbios-devel/fs/hfs/hfs_fs.c Thu Jun 10 20:35:25 2010 (r793) @@ -466,4 +466,4 @@ return -1; return 0; -} \ No newline at end of file +} Modified: trunk/openbios-devel/fs/hfs/volume.c ============================================================================== --- trunk/openbios-devel/fs/hfs/volume.c Thu Jun 10 00:30:32 2010 (r792) +++ trunk/openbios-devel/fs/hfs/volume.c Thu Jun 10 20:35:25 2010 (r793) @@ -609,4 +609,4 @@ free(mdb); return -1; -} \ No newline at end of file +} Modified: trunk/openbios-devel/fs/hfsplus/hfsp_fs.c ============================================================================== --- trunk/openbios-devel/fs/hfsplus/hfsp_fs.c Thu Jun 10 00:30:32 2010 (r792) +++ trunk/openbios-devel/fs/hfsplus/hfsp_fs.c Thu Jun 10 20:35:25 2010 (r793) @@ -405,4 +405,4 @@ return -1; return 0; -} \ No newline at end of file +} Modified: trunk/openbios-devel/fs/hfsplus/volume.c ============================================================================== --- trunk/openbios-devel/fs/hfsplus/volume.c Thu Jun 10 00:30:32 2010 (r792) +++ trunk/openbios-devel/fs/hfsplus/volume.c Thu Jun 10 20:35:25 2010 (r793) @@ -307,4 +307,4 @@ free(vol); return -1; -} \ No newline at end of file +}

6 18

[commit] r795 - trunk/openbios-devel/packages
by repository service 15 Jun '10

15 Jun '10

Author: mcayland Date: Tue Jun 15 21:59:47 2010 New Revision: 795 URL: http://tracker.coreboot.org/trac/openbios/changeset/795 Log: Fix partition string parsing code so that it correctly handles boot strings beginning with a comma of the form <device>,\path\to\file. This fixes all outstanding issues with PPC. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/packages/mac-parts.c trunk/openbios-devel/packages/pc-parts.c trunk/openbios-devel/packages/sun-parts.c Modified: trunk/openbios-devel/packages/mac-parts.c ============================================================================== --- trunk/openbios-devel/packages/mac-parts.c Tue Jun 15 18:31:54 2010 (r794) +++ trunk/openbios-devel/packages/mac-parts.c Tue Jun 15 21:59:47 2010 (r795) @@ -62,26 +62,37 @@ /* Arguments that we accept: id: [0-7] - [(id,)][filespec] + [(id)][,][filespec] */ if( str ) { if ( !strlen(str) ) parnum = -1; else { - /* If end of string, we just have a partition id */ - if (str[1] == '\0') { - parstr = str; - } else { - /* If a comma, then we have a partition id plus argument */ - if (str[1] == ',') { - str[1] = '\0'; - parstr = str; - argstr = &str[2]; - } else { - /* Otherwise we have just an argument */ - argstr = str; - } + /* Detect the boot parameters */ + char *ptr; + ptr = str; + + /* <id>,<file> */ + if (*ptr >= '0' && *ptr <= '9' && *(ptr + 1) == ',') { + parstr = ptr; + *(ptr + 1) = '\0'; + argstr = ptr + 2; + } + + /* <id> */ + else if (*ptr >= '0' && *ptr <='9' && *(ptr + 1) == '\0') { + parstr = ptr; + } + + /* ,<file> */ + else if (*ptr == ',') { + argstr = ptr + 1; + } + + /* <file> */ + else { + argstr = str; } /* Convert the id to a partition number */ Modified: trunk/openbios-devel/packages/pc-parts.c ============================================================================== --- trunk/openbios-devel/packages/pc-parts.c Tue Jun 15 18:31:54 2010 (r794) +++ trunk/openbios-devel/packages/pc-parts.c Tue Jun 15 21:59:47 2010 (r795) @@ -89,26 +89,37 @@ /* Arguments that we accept: id: [0-7] - [(id,)][filespec] + [(id)][,][filespec] */ if( str ) { if ( !strlen(str) ) parnum = -1; else { - /* If end of string, we just have a partition id */ - if (str[1] == '\0') { - parstr = str; - } else { - /* If a comma, then we have a partition id plus argument */ - if (str[1] == ',') { - str[1] = '\0'; - parstr = str; - argstr = &str[2]; - } else { - /* Otherwise we have just an argument */ - argstr = str; - } + /* Detect the boot parameters */ + char *ptr; + ptr = str; + + /* <id>,<file> */ + if (*ptr >= '0' && *ptr <= '9' && *(ptr + 1) == ',') { + parstr = ptr; + *(ptr + 1) = '\0'; + argstr = ptr + 2; + } + + /* <id> */ + else if (*ptr >= '0' && *ptr <='9' && *(ptr + 1) == '\0') { + parstr = ptr; + } + + /* ,<file> */ + else if (*ptr == ',') { + argstr = ptr + 1; + } + + /* <file> */ + else { + argstr = str; } /* Convert the id to a partition number */ Modified: trunk/openbios-devel/packages/sun-parts.c ============================================================================== --- trunk/openbios-devel/packages/sun-parts.c Tue Jun 15 18:31:54 2010 (r794) +++ trunk/openbios-devel/packages/sun-parts.c Tue Jun 15 21:59:47 2010 (r795) @@ -106,26 +106,37 @@ /* Arguments that we accept: id: [0-7] | [a-h] - [(id,)][filespec] + [(id)][,][filespec] */ if( str ) { if ( !strlen(str) ) parnum = -1; else { - /* If end of string, we just have a partition id */ - if (str[1] == '\0') { - parstr = str; - } else { - /* If a comma, then we have a partition id plus argument */ - if (str[1] == ',') { - str[1] = '\0'; - parstr = str; - argstr = &str[2]; - } else { - /* Otherwise we have just an argument */ - argstr = str; - } + /* Detect the boot parameters */ + char *ptr; + ptr = str; + + /* <id>,<file> */ + if (((*ptr >= '0' && *ptr <= '9') || (*ptr >= 'a' && *ptr <= 'a' + 8)) && *(ptr + 1) == ',') { + parstr = ptr; + *(ptr + 1) = '\0'; + argstr = ptr + 2; + } + + /* <id> */ + else if (((*ptr >= '0' && *ptr <= '9') || (*ptr >= 'a' && *ptr <= 'a' + 8)) && *(ptr + 1) == '\0') { + parstr = ptr; + } + + /* ,<file> */ + else if (*ptr == ',') { + argstr = ptr + 1; + } + + /* <file> */ + else { + argstr = str; } /* Convert the id to a partition number */ @@ -134,7 +145,7 @@ parnum = parstr[0] - 'a'; else parnum = atol(parstr); - } + } } }

1 0

[commit] r794 - in trunk/openbios-devel: fs/hfsplus packages
by repository service 15 Jun '10

15 Jun '10

Author: mcayland Date: Tue Jun 15 18:31:54 2010 New Revision: 794 URL: http://tracker.coreboot.org/trac/openbios/changeset/794 Log: Fix the HFSP probe function, plus also resolve an off-by-one error in the mac-parts partition code. This should fix PPC boot once again. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/fs/hfsplus/volume.c trunk/openbios-devel/packages/mac-parts.c Modified: trunk/openbios-devel/fs/hfsplus/volume.c ============================================================================== --- trunk/openbios-devel/fs/hfsplus/volume.c Thu Jun 10 20:35:25 2010 (r793) +++ trunk/openbios-devel/fs/hfsplus/volume.c Tue Jun 15 18:31:54 2010 (r794) @@ -294,17 +294,21 @@ int volume_probe(int fd, llong offset) { - struct hfsp_vh *vol; + UInt16 *vol; + int ret = 0; - vol = (struct hfsp_vh*)malloc(2 * 1 << HFSP_BLOCKSZ_BITS); + vol = (UInt16 *)malloc(2 * 1 << HFSP_BLOCKSZ_BITS); os_seek_offset( fd, 2 * (1 << HFSP_BLOCKSZ_BITS) + offset ); os_read(fd, vol, 2, HFSP_BLOCKSZ_BITS); - if (__be16_to_cpu(vol->signature) != HFSP_VOLHEAD_SIG) { - free(vol); - return 0; + if (__be16_to_cpu(vol[0]) == HFS_VOLHEAD_SIG && + __be16_to_cpu(vol[0x7c]) == HFSP_VOLHEAD_SIG) { + ret = -1; + } else if (__be16_to_cpu(vol[0]) == HFSP_VOLHEAD_SIG) { + ret = -1; } free(vol); - return -1; + return ret; } + Modified: trunk/openbios-devel/packages/mac-parts.c ============================================================================== --- trunk/openbios-devel/packages/mac-parts.c Thu Jun 10 20:35:25 2010 (r793) +++ trunk/openbios-devel/packages/mac-parts.c Tue Jun 15 18:31:54 2010 (r794) @@ -127,13 +127,12 @@ /* search a bootable partition */ /* see PowerPC Microprocessor CHRP bindings */ - parnum = 1; - while (parnum <= __be32_to_cpu(par.pmMapBlkCnt)) { - SEEK( (bs * parnum) ); + for (parnum = 0; parnum <= __be32_to_cpu(par.pmMapBlkCnt); parnum++) { + SEEK( (bs * (parnum + 1)) ); READ( &par, sizeof(par) ); if( __be16_to_cpu(par.pmSig) != DESC_PART_SIGNATURE || !__be16_to_cpu(par.pmPartBlkCnt) ) - goto out; + break; DPRINTF("found partition type: %s\n", par.pmPartType); @@ -169,7 +168,6 @@ goto out; } - parnum++; } /* not found */ if (firstHFS != -1) { @@ -199,7 +197,7 @@ goto out; found: - SEEK( (bs * parnum) ); + SEEK( (bs * (parnum + 1)) ); READ( &par, sizeof(par) ); if( __be16_to_cpu(par.pmSig) != DESC_PART_SIGNATURE || !__be32_to_cpu(par.pmPartBlkCnt) ) goto out;

1 0

[commit] r792 - in trunk/openbios-devel: fs fs/ext2 fs/hfs fs/hfs/include fs/hfsplus fs/hfsplus/include include/fs packages
by repository service 10 Jun '10

10 Jun '10

Author: mcayland Date: Thu Jun 10 00:30:32 2010 New Revision: 792 URL: http://tracker.coreboot.org/trac/openbios/changeset/792 Log: Fix up the majority of the non-grubfs filesystems from my last commit, since they require a "probe with offset" function to allow the partition handler to identify a valid FS before interposition to /packages/misc-files. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/fs/ext2/ext2_fs.c trunk/openbios-devel/fs/ext2/ext2_utils.c trunk/openbios-devel/fs/ext2/ext2_utils.h trunk/openbios-devel/fs/hfs/hfs.c trunk/openbios-devel/fs/hfs/hfs_fs.c trunk/openbios-devel/fs/hfs/include/hfs.h trunk/openbios-devel/fs/hfs/include/volume.h trunk/openbios-devel/fs/hfs/volume.c trunk/openbios-devel/fs/hfsplus/hfsp_fs.c trunk/openbios-devel/fs/hfsplus/include/volume.h trunk/openbios-devel/fs/hfsplus/volume.c trunk/openbios-devel/fs/ioglue.c trunk/openbios-devel/fs/os.h trunk/openbios-devel/include/fs/fs.h trunk/openbios-devel/packages/misc-files.c Modified: trunk/openbios-devel/fs/ext2/ext2_fs.c ============================================================================== --- trunk/openbios-devel/fs/ext2/ext2_fs.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/ext2/ext2_fs.c Thu Jun 10 00:30:32 2010 (r792) @@ -201,3 +201,11 @@ return 0; } + +int fs_ext2_probe(int fd, llong offs) +{ + if (ext2_probe(fd, offs)) + return -1; + + return 0; +} Modified: trunk/openbios-devel/fs/ext2/ext2_utils.c ============================================================================== --- trunk/openbios-devel/fs/ext2/ext2_utils.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/ext2/ext2_utils.c Thu Jun 10 00:30:32 2010 (r792) @@ -12,6 +12,23 @@ #include "libc/diskio.h" #include "libc/byteorder.h" +int ext2_probe(int fd, llong offset) +{ + struct ext2_super_block *super; + + super = (struct ext2_super_block*)malloc(sizeof(struct ext2_super_block)); + seek_io(fd, 2 * 512 + offset); + read_io(fd, super, sizeof (*super)); + + if (__be16_to_cpu(super->s_magic) != EXT2_SUPER_MAGIC) { + free(super); + return 0; + } + + free(super); + return -1; +} + void ext2_get_super(int fd, struct ext2_super_block *super) { seek_io(fd, 2 * 512); Modified: trunk/openbios-devel/fs/ext2/ext2_utils.h ============================================================================== --- trunk/openbios-devel/fs/ext2/ext2_utils.h Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/ext2/ext2_utils.h Thu Jun 10 00:30:32 2010 (r792) @@ -36,6 +36,7 @@ /* utilities */ +extern int ext2_probe(int fd, llong offset); extern void ext2_get_super(int fd, struct ext2_super_block *super); extern void ext2_read_block(ext2_VOLUME* volume, unsigned int fsblock); extern void ext2_get_group_desc(ext2_VOLUME* volume, Modified: trunk/openbios-devel/fs/hfs/hfs.c ============================================================================== --- trunk/openbios-devel/fs/hfs/hfs.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/hfs/hfs.c Thu Jun 10 00:30:32 2010 (r792) @@ -736,3 +736,12 @@ return 0; } + +/* + * NAME: hfs->probe() + * DESCRIPTION: return whether a HFS filesystem is present at the given offset + */ +int hfs_probe(int fd, llong offset) +{ + return v_probe(fd, offset); +} Modified: trunk/openbios-devel/fs/hfs/hfs_fs.c ============================================================================== --- trunk/openbios-devel/fs/hfs/hfs_fs.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/hfs/hfs_fs.c Thu Jun 10 00:30:32 2010 (r792) @@ -458,3 +458,12 @@ return 0; } + +int +fs_hfs_probe( int fd, llong offs ) +{ + if (hfs_probe(fd, offs)) + return -1; + + return 0; +} \ No newline at end of file Modified: trunk/openbios-devel/fs/hfs/include/hfs.h ============================================================================== --- trunk/openbios-devel/fs/hfs/include/hfs.h Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/hfs/include/hfs.h Thu Jun 10 00:30:32 2010 (r792) @@ -177,3 +177,4 @@ int hfs_format(const char *, int, int, const char *, unsigned int, const unsigned long []); +int hfs_probe(int fd, llong offset); Modified: trunk/openbios-devel/fs/hfs/include/volume.h ============================================================================== --- trunk/openbios-devel/fs/hfs/include/volume.h Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/hfs/include/volume.h Thu Jun 10 00:30:32 2010 (r792) @@ -66,5 +66,6 @@ int v_scavenge(hfsvol *); +int v_probe(int fd, llong offset); #endif /* _H_VOLUME */ Modified: trunk/openbios-devel/fs/hfs/volume.c ============================================================================== --- trunk/openbios-devel/fs/hfs/volume.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/hfs/volume.c Thu Jun 10 00:30:32 2010 (r792) @@ -32,6 +32,8 @@ #include "record.h" #include "os.h" +#include "libc/byteorder.h" + /* * NAME: vol->init() * DESCRIPTION: initialize volume structure @@ -589,3 +591,22 @@ fail: return -1; } + +/* Determine whether the volume is a HFS volume */ +int +v_probe(int fd, llong offset) +{ + MDB *mdb; + + mdb = (MDB*)malloc(2 * 512); + os_seek_offset( fd, 2 * 512 + offset ); + os_read(fd, mdb, 2, 9); + + if (__be16_to_cpu(mdb->drSigWord) != HFS_SIGWORD) { + free(mdb); + return 0; + } + + free(mdb); + return -1; +} \ No newline at end of file Modified: trunk/openbios-devel/fs/hfsplus/hfsp_fs.c ============================================================================== --- trunk/openbios-devel/fs/hfsplus/hfsp_fs.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/hfsplus/hfsp_fs.c Thu Jun 10 00:30:32 2010 (r792) @@ -397,3 +397,12 @@ return 0; } + +int +fs_hfsp_probe(int fd, llong offs) +{ + if (volume_probe(fd, offs)) + return -1; + + return 0; +} \ No newline at end of file Modified: trunk/openbios-devel/fs/hfsplus/include/volume.h ============================================================================== --- trunk/openbios-devel/fs/hfsplus/include/volume.h Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/hfsplus/include/volume.h Thu Jun 10 00:30:32 2010 (r792) @@ -72,6 +72,8 @@ return vol->extents; } +/* Determine whether the volume is a HFS-plus volume */ +int volume_probe(int fd, llong offset); #ifdef DEBUG /* Print raw fork information to stdout */ Modified: trunk/openbios-devel/fs/hfsplus/volume.c ============================================================================== --- trunk/openbios-devel/fs/hfsplus/volume.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/hfsplus/volume.c Thu Jun 10 00:30:32 2010 (r792) @@ -35,6 +35,7 @@ #include "swab.h" #include "hfstime.h" + /* Fill a given buffer with the given block in volume. */ int @@ -288,3 +289,22 @@ fail: vol->extents = NULL; } + +/* Determine whether the volume is a HFS-plus volume */ +int +volume_probe(int fd, llong offset) +{ + struct hfsp_vh *vol; + + vol = (struct hfsp_vh*)malloc(2 * 1 << HFSP_BLOCKSZ_BITS); + os_seek_offset( fd, 2 * (1 << HFSP_BLOCKSZ_BITS) + offset ); + os_read(fd, vol, 2, HFSP_BLOCKSZ_BITS); + + if (__be16_to_cpu(vol->signature) != HFSP_VOLHEAD_SIG) { + free(vol); + return 0; + } + + free(vol); + return -1; +} \ No newline at end of file Modified: trunk/openbios-devel/fs/ioglue.c ============================================================================== --- trunk/openbios-devel/fs/ioglue.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/ioglue.c Thu Jun 10 00:30:32 2010 (r792) @@ -79,6 +79,12 @@ return blknum; } +void +os_seek_offset( int fd, llong offset ) +{ + seek_io(fd, offset); +} + int os_same( int fd1, int fd2 ) { Modified: trunk/openbios-devel/fs/os.h ============================================================================== --- trunk/openbios-devel/fs/os.h Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/fs/os.h Thu Jun 10 00:30:32 2010 (r792) @@ -47,5 +47,11 @@ */ unsigned long os_write( int fd, const void *buf, unsigned long len, int blksize_bits); +/* + * NAME: os->seek_offset() + * DESCRIPTION: set a descriptor's seek pointer (offset in bytes) + */ +void os_seek_offset( int fd, llong offset ); + #endif /* _H_OS */ Modified: trunk/openbios-devel/include/fs/fs.h ============================================================================== --- trunk/openbios-devel/include/fs/fs.h Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/include/fs/fs.h Thu Jun 10 00:30:32 2010 (r792) @@ -53,14 +53,18 @@ #ifdef CONFIG_HFSP extern int fs_hfsp_open( int fd, fs_ops_t *fs ); +extern int fs_hfsp_probe( int fd, llong offs ); #else static inline int fs_hfsp_open( int fd, fs_ops_t *fs ) { return -1; } +static inline int fs_hfsp_probe( int fd, llong offs ) { return -1; } #endif #ifdef CONFIG_HFS extern int fs_hfs_open( int fd, fs_ops_t *fs ); +extern int fs_hfs_probe( int fd, llong offs ); #else static inline int fs_hfs_open( int fd, fs_ops_t *fs ) { return -1; } +static inline int fs_hfs_probe( int fd, llong offs ) { return -1; } #endif #ifdef CONFIG_ISO9660 @@ -71,8 +75,10 @@ #ifdef CONFIG_EXT2 extern int fs_ext2_open( int fd, fs_ops_t *fs ); +extern int fs_ext2_probe( int fd, llong offs ); #else static inline int fs_ext2_open( int fd, fs_ops_t *fs ) { return -1; } +static inline int fs_ext2_probe( int fd, llong offs ) { return -1; } #endif #ifdef CONFIG_GRUBFS @@ -80,6 +86,7 @@ extern int fs_grubfs_probe( int fd, llong offs ); #else static inline int fs_grubfs_open( int fd, fs_ops_t *fs ) { return -1; } +static inline int fs_grubfs_probe( int fd, llong offs ) { return -1; } #endif Modified: trunk/openbios-devel/packages/misc-files.c ============================================================================== --- trunk/openbios-devel/packages/misc-files.c Tue Jun 8 22:59:08 2010 (r791) +++ trunk/openbios-devel/packages/misc-files.c Thu Jun 10 00:30:32 2010 (r792) @@ -351,25 +351,24 @@ err = (fd = open_ih(ih)) == -1; if( !err ) { - /* - err = fs_hfsp_open(fd, fs); + + err = fs_hfsp_probe(fd, offs); DPRINTF("--- HFSP returned %d\n", err); if( err ) { - err = fs_hfs_open(fd, fs); + err = fs_hfs_probe(fd, offs); DPRINTF("--- HFS returned %d\n", err); } - +/* if( err ) { err = fs_iso9660_open(fd, fs); DPRINTF("--- ISO9660 returned %d\n", err); } - +*/ if( err ) { - err = fs_ext2_open(fd, fs); + err = fs_ext2_probe(fd, offs); DPRINTF("--- ext2 returned %d\n", err); } - */ if( err ) { err = fs_grubfs_probe(fd, offs);

1 0

Re: [OpenBIOS] when I push the enter button...
by Programmingkid 09 Jun '10

09 Jun '10

On Jun 8, 2010, at 6:00 AM, openbios-request(a)openbios.org wrote: > Programmingkid wrote: > >> What code starts executing when I push the enter key in an OpenBIOS session? I thought it was interpret, but it isn't. > > Possibly the console code in packages/cmdline.c? > > > HTH, > > Mark. Thank you Mark for your help.

1 0