OpenBIOS October 2010

openbios@openbios.org

14 participants
92 discussions

Start a nNew thread

do anyone have self-study free book of Forth?
by kim.jin 18 Oct '10

18 Oct '10

hi, do you have any book for me to self-study? Best Regards! Kim King 2010-10-14

2 2

[commit] r914 - trunk/openbios-devel/arch/ppc/qemu
by repository service 17 Oct '10

17 Oct '10

Author: agraf Date: Sun Oct 17 14:15:44 2010 New Revision: 914 URL: http://tracker.coreboot.org/trac/openbios/changeset/914 Log: ppc: Move noreturn attribute Otherwise GCC 4.2.4 complains that panic() marked noreturn does return. Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> Signed-off-by: Alexander Graf <agraf(a)suse.de> Modified: trunk/openbios-devel/arch/ppc/qemu/kernel.h trunk/openbios-devel/arch/ppc/qemu/qemu.c Modified: trunk/openbios-devel/arch/ppc/qemu/kernel.h ============================================================================== --- trunk/openbios-devel/arch/ppc/qemu/kernel.h Sun Oct 17 11:13:14 2010 (r913) +++ trunk/openbios-devel/arch/ppc/qemu/kernel.h Sun Oct 17 14:15:44 2010 (r914) @@ -17,7 +17,7 @@ /* misc.c */ extern void fatal_error( const char *str ); -extern void exit( int status ); +extern void exit( int status ) __attribute__ ((noreturn)); /* start.S */ extern void flush_icache_range( char *start, char *stop ); Modified: trunk/openbios-devel/arch/ppc/qemu/qemu.c ============================================================================== --- trunk/openbios-devel/arch/ppc/qemu/qemu.c Sun Oct 17 11:13:14 2010 (r913) +++ trunk/openbios-devel/arch/ppc/qemu/qemu.c Sun Oct 17 14:15:44 2010 (r914) @@ -35,7 +35,7 @@ exit( int status __attribute__ ((unused))) { for (;;); -} __attribute__ ((noreturn)) +} void fatal_error( const char *err )

1 0

[commit] r913 - trunk/openbios-devel/libopenbios
by repository service 17 Oct '10

17 Oct '10

Author: mcayland Date: Sun Oct 17 11:13:14 2010 New Revision: 913 URL: http://tracker.coreboot.org/trac/openbios/changeset/913 Log: Fix comment typo from r896 as pointed out by Andreas. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/libopenbios/ofmem_common.c Modified: trunk/openbios-devel/libopenbios/ofmem_common.c ============================================================================== --- trunk/openbios-devel/libopenbios/ofmem_common.c Sun Oct 17 11:10:09 2010 (r912) +++ trunk/openbios-devel/libopenbios/ofmem_common.c Sun Oct 17 11:13:14 2010 (r913) @@ -211,7 +211,7 @@ if (prop_used > trans_prop_size) { - /* The property doesn't fix within the existing space, so keep doubling it + /* The property doesn't fit within the existing space, so keep doubling it until it does */ prop_size = trans_prop_size; while (prop_size < prop_used) { @@ -262,7 +262,7 @@ if (prop_used > *mem_prop_size) { - /* The property doesn't fix within the existing space, so keep doubling it + /* The property doesn't fit within the existing space, so keep doubling it until it does */ prop_size = *mem_prop_size; while (prop_size < prop_used) {

1 0

[commit] r912 - trunk/openbios-devel/forth/bootstrap
by repository service 17 Oct '10

17 Oct '10

Author: mcayland Date: Sun Oct 17 11:10:09 2010 New Revision: 912 URL: http://tracker.coreboot.org/trac/openbios/changeset/912 Log: Fix up the new 2>r, 2r> and 2r@ words. As pointed out by Tarl, since these are called as separate words (and not inline), we need to preserve the top-most R stack item as this is return address of the word itself. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/forth/bootstrap/bootstrap.fs Modified: trunk/openbios-devel/forth/bootstrap/bootstrap.fs ============================================================================== --- trunk/openbios-devel/forth/bootstrap/bootstrap.fs Sun Oct 17 00:37:31 2010 (r911) +++ trunk/openbios-devel/forth/bootstrap/bootstrap.fs Sun Oct 17 11:10:09 2010 (r912) @@ -411,9 +411,9 @@ \ Note: these words are not part of the official OF specification, however \ they are part of the ANSI DPANS94 core extensions (see section 6.2) and \ so this seems an appropriate place for them. -: 2>r swap >r >r ; -: 2r> r> r> swap ; -: 2r@ r> r> 2dup >r >r swap ; +: 2>r r> -rot swap >r >r >r ; +: 2r> r> r> r> rot >r swap ; +: 2r@ r> r> r> 2dup >r >r rot >r swap ; \ \ 7.3.2.1 - single precision integer arithmetic (part 1)

1 0

[commit] r910 - trunk/openbios-devel/forth/system
by repository service 17 Oct '10

17 Oct '10

Author: mcayland Date: Sun Oct 17 00:21:51 2010 New Revision: 910 URL: http://tracker.coreboot.org/trac/openbios/changeset/910 Log: Force any errors in the CIF interpret word to reset the Forth engine back to the Forth interpret state. This fixes various errors being caused by previous calls to CIF interpret throwing exceptions whilst in the Forth compile state. Without this fix, subsequent calls to CIF interpret could be executed erroneusly in Forth compile state rather than the Forth interpret state causing hard-to-detect Forth errors. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland(a)siriusit.co.uk> Modified: trunk/openbios-devel/forth/system/ciface.fs Modified: trunk/openbios-devel/forth/system/ciface.fs ============================================================================== --- trunk/openbios-devel/forth/system/ciface.fs Sat Oct 16 19:36:22 2010 (r909) +++ trunk/openbios-devel/forth/system/ciface.fs Sun Oct 17 00:21:51 2010 (r910) @@ -273,6 +273,10 @@ ['] evaluate catch dup if \ this is not necessary an error... ." interpret: exception " dup . ." caught" cr + + \ Force back to interpret state on error, otherwise the next call to + \ interpret gets confused if the error occurred in compile mode + 0 state ! then \ ." --- " cr ;

1 0

[PATCH] ppc: Use config file to enable RTAS
by Andreas Färber 16 Oct '10

16 Oct '10

RTAS had to be enabled via EXTRACFLAGS=-DUSE_RTAS. Use the config file instead. Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> --- arch/ppc/briq/init.c | 4 ++-- arch/ppc/briq/methods.c | 4 ++-- arch/ppc/pearpc/init.c | 4 ++-- arch/ppc/pearpc/methods.c | 4 ++-- arch/ppc/qemu/init.c | 4 ++-- arch/ppc/qemu/methods.c | 4 ++-- config/examples/ppc_config.xml | 1 + 7 files changed, 13 insertions(+), 12 deletions(-) diff --git a/arch/ppc/briq/init.c b/arch/ppc/briq/init.c index 14abe96..0b2b3b9 100644 --- a/arch/ppc/briq/init.c +++ b/arch/ppc/briq/init.c @@ -85,7 +85,7 @@ setenv( char *env, char *value ) void arch_of_init( void ) { -#if USE_RTAS +#if CONFIG_RTAS phandle_t ph; #endif int autoboot; @@ -98,7 +98,7 @@ arch_of_init( void ) ob_pci_init(); #endif -#if USE_RTAS +#if CONFIG_RTAS if( !(ph=find_dev("/rtas")) ) printk("Warning: No /rtas node\n"); else { diff --git a/arch/ppc/briq/methods.c b/arch/ppc/briq/methods.c index 9978f04..649e9ba 100644 --- a/arch/ppc/briq/methods.c +++ b/arch/ppc/briq/methods.c @@ -28,7 +28,7 @@ /* RTAS (run-time abstraction services) */ /************************************************************************/ -#ifdef USE_RTAS +#ifdef CONFIG_RTAS DECLARE_NODE( rtas, INSTALL_OPEN, 0, "+/rtas" ); /* ( physbase -- rtas_callback ) */ @@ -321,7 +321,7 @@ NODE_METHODS( mmu_ciface ) = { void node_methods_init( void ) { -#ifdef USE_RTAS +#ifdef CONFIG_RTAS REGISTER_NODE( rtas ); #endif REGISTER_NODE( vfd_stdout ); diff --git a/arch/ppc/pearpc/init.c b/arch/ppc/pearpc/init.c index 55b3aae..b2c11c9 100644 --- a/arch/ppc/pearpc/init.c +++ b/arch/ppc/pearpc/init.c @@ -88,7 +88,7 @@ setenv( char *env, char *value ) void arch_of_init( void ) { -#if USE_RTAS +#if CONFIG_RTAS phandle_t ph; #endif int autoboot; @@ -104,7 +104,7 @@ arch_of_init( void ) node_methods_init(); init_video(); -#if USE_RTAS +#if CONFIG_RTAS if( !(ph=find_dev("/rtas")) ) printk("Warning: No /rtas node\n"); else { diff --git a/arch/ppc/pearpc/methods.c b/arch/ppc/pearpc/methods.c index ae3ab44..f505b6c 100644 --- a/arch/ppc/pearpc/methods.c +++ b/arch/ppc/pearpc/methods.c @@ -28,7 +28,7 @@ /* RTAS (run-time abstraction services) */ /************************************************************************/ -#ifdef USE_RTAS +#ifdef CONFIG_RTAS DECLARE_NODE( rtas, INSTALL_OPEN, 0, "+/rtas" ); /* ( physbase -- rtas_callback ) */ @@ -317,7 +317,7 @@ NODE_METHODS( mmu_ciface ) = { void node_methods_init( void ) { -#ifdef USE_RTAS +#ifdef CONFIG_RTAS REGISTER_NODE( rtas ); #endif REGISTER_NODE( video_stdout ); diff --git a/arch/ppc/qemu/init.c b/arch/ppc/qemu/init.c index 0d0db3a..3979f5d 100644 --- a/arch/ppc/qemu/init.c +++ b/arch/ppc/qemu/init.c @@ -572,7 +572,7 @@ static void kvm_of_init(void) void arch_of_init( void ) { -#ifdef USE_RTAS +#ifdef CONFIG_RTAS phandle_t ph; #endif uint64_t ram_size; @@ -730,7 +730,7 @@ arch_of_init( void ) ofmem_register(find_dev("/memory"), find_dev(buf)); node_methods_init(buf); -#ifdef USE_RTAS +#ifdef CONFIG_RTAS if( !(ph=find_dev("/rtas")) ) printk("Warning: No /rtas node\n"); else { diff --git a/arch/ppc/qemu/methods.c b/arch/ppc/qemu/methods.c index cf307f9..71a364f 100644 --- a/arch/ppc/qemu/methods.c +++ b/arch/ppc/qemu/methods.c @@ -30,7 +30,7 @@ /* RTAS (run-time abstraction services) */ /************************************************************************/ -#ifdef USE_RTAS +#ifdef CONFIG_RTAS DECLARE_NODE( rtas, INSTALL_OPEN, 0, "+/rtas" ); /* ( physbase -- rtas_callback ) */ @@ -303,7 +303,7 @@ void node_methods_init( const char *cpuname ) { phandle_t chosen, ph; -#ifdef USE_RTAS +#ifdef CONFIG_RTAS REGISTER_NODE( rtas ); #endif REGISTER_NODE( ciface ); diff --git a/config/examples/ppc_config.xml b/config/examples/ppc_config.xml index cfe57e1..5f79c21 100644 --- a/config/examples/ppc_config.xml +++ b/config/examples/ppc_config.xml @@ -58,6 +58,7 @@  <option name="CONFIG_LINUXBIOS" type="boolean" value="false"/> + <option name="CONFIG_RTAS" type="boolean" value="false"/>  <option name="CONFIG_DRIVER_PCI" type="boolean" value="true"/> -- 1.7.3

2 1

Q: qemu ppc ofmem memory layout
by Andreas Färber 16 Oct '10

16 Oct '10

Hello, In arch/ppc/qemu/ofmem.c, ofmem appears to be located at OFMEM == 0x05400000 == 84 MiB, with OF_MALLOC_BASE at OFMEM + sizeof(ofmem_t) 4- byte aligned. The upper limit from libopenbios/ofmem_common.c seems to be ofmem_arch_get_heap_top() == "hash base minus fixed value" though, with the hash base being relative to top of RAM. This means, the malloc zone has a fixed lower limit and grows absolutely with the amount of RAM assigned to QEMU. Is this really intended? The code comment in ofmem.c rather looks like the fixed OFMEM value was taken from a 96 MB memory layout, where it would seem relative to top of RAM with fixed size. Even worse, like any other memory on ppc this hugeish part of memory is never claimed... I tried to move ofmem to RAM size - 0x100000 - 64 * 1024 - (32 + 64 + 64) * 1024 - 0x200000, but OpenBIOS just busy-looped and never reached the banner. Has anyone looked into this before? Any ideas what might be going wrong? I tried carefully not to include a call to ofmem_arch_get_private() inside setup_mmu(). Regards, Andreas

4 23

[commit] r909 - in trunk/openbios-devel: arch/ppc/briq arch/ppc/pearpc arch/ppc/qemu config/examples
by repository service 16 Oct '10

16 Oct '10

Author: blueswirl Date: Sat Oct 16 19:36:22 2010 New Revision: 909 URL: http://tracker.coreboot.org/trac/openbios/changeset/909 Log: ppc: Use config file to enable RTAS RTAS had to be enabled via EXTRACFLAGS=-DUSE_RTAS. Use the config file instead. Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/arch/ppc/briq/init.c trunk/openbios-devel/arch/ppc/briq/methods.c trunk/openbios-devel/arch/ppc/pearpc/init.c trunk/openbios-devel/arch/ppc/pearpc/methods.c trunk/openbios-devel/arch/ppc/qemu/init.c trunk/openbios-devel/arch/ppc/qemu/methods.c trunk/openbios-devel/config/examples/ppc_config.xml Modified: trunk/openbios-devel/arch/ppc/briq/init.c ============================================================================== --- trunk/openbios-devel/arch/ppc/briq/init.c Sat Oct 16 19:36:18 2010 (r908) +++ trunk/openbios-devel/arch/ppc/briq/init.c Sat Oct 16 19:36:22 2010 (r909) @@ -85,7 +85,7 @@ void arch_of_init( void ) { -#if USE_RTAS +#if CONFIG_RTAS phandle_t ph; #endif int autoboot; @@ -98,7 +98,7 @@ ob_pci_init(); #endif -#if USE_RTAS +#if CONFIG_RTAS if( !(ph=find_dev("/rtas")) ) printk("Warning: No /rtas node\n"); else { Modified: trunk/openbios-devel/arch/ppc/briq/methods.c ============================================================================== --- trunk/openbios-devel/arch/ppc/briq/methods.c Sat Oct 16 19:36:18 2010 (r908) +++ trunk/openbios-devel/arch/ppc/briq/methods.c Sat Oct 16 19:36:22 2010 (r909) @@ -28,7 +28,7 @@ /* RTAS (run-time abstraction services) */ /************************************************************************/ -#ifdef USE_RTAS +#ifdef CONFIG_RTAS DECLARE_NODE( rtas, INSTALL_OPEN, 0, "+/rtas" ); /* ( physbase -- rtas_callback ) */ @@ -321,7 +321,7 @@ void node_methods_init( void ) { -#ifdef USE_RTAS +#ifdef CONFIG_RTAS REGISTER_NODE( rtas ); #endif REGISTER_NODE( vfd_stdout ); Modified: trunk/openbios-devel/arch/ppc/pearpc/init.c ============================================================================== --- trunk/openbios-devel/arch/ppc/pearpc/init.c Sat Oct 16 19:36:18 2010 (r908) +++ trunk/openbios-devel/arch/ppc/pearpc/init.c Sat Oct 16 19:36:22 2010 (r909) @@ -88,7 +88,7 @@ void arch_of_init( void ) { -#if USE_RTAS +#if CONFIG_RTAS phandle_t ph; #endif int autoboot; @@ -104,7 +104,7 @@ node_methods_init(); init_video(); -#if USE_RTAS +#if CONFIG_RTAS if( !(ph=find_dev("/rtas")) ) printk("Warning: No /rtas node\n"); else { Modified: trunk/openbios-devel/arch/ppc/pearpc/methods.c ============================================================================== --- trunk/openbios-devel/arch/ppc/pearpc/methods.c Sat Oct 16 19:36:18 2010 (r908) +++ trunk/openbios-devel/arch/ppc/pearpc/methods.c Sat Oct 16 19:36:22 2010 (r909) @@ -28,7 +28,7 @@ /* RTAS (run-time abstraction services) */ /************************************************************************/ -#ifdef USE_RTAS +#ifdef CONFIG_RTAS DECLARE_NODE( rtas, INSTALL_OPEN, 0, "+/rtas" ); /* ( physbase -- rtas_callback ) */ @@ -317,7 +317,7 @@ void node_methods_init( void ) { -#ifdef USE_RTAS +#ifdef CONFIG_RTAS REGISTER_NODE( rtas ); #endif REGISTER_NODE( video_stdout ); Modified: trunk/openbios-devel/arch/ppc/qemu/init.c ============================================================================== --- trunk/openbios-devel/arch/ppc/qemu/init.c Sat Oct 16 19:36:18 2010 (r908) +++ trunk/openbios-devel/arch/ppc/qemu/init.c Sat Oct 16 19:36:22 2010 (r909) @@ -582,7 +582,7 @@ void arch_of_init( void ) { -#ifdef USE_RTAS +#ifdef CONFIG_RTAS phandle_t ph; #endif uint64_t ram_size; @@ -740,7 +740,7 @@ ofmem_register(find_dev("/memory"), find_dev(buf)); node_methods_init(buf); -#ifdef USE_RTAS +#ifdef CONFIG_RTAS if( !(ph=find_dev("/rtas")) ) printk("Warning: No /rtas node\n"); else { Modified: trunk/openbios-devel/arch/ppc/qemu/methods.c ============================================================================== --- trunk/openbios-devel/arch/ppc/qemu/methods.c Sat Oct 16 19:36:18 2010 (r908) +++ trunk/openbios-devel/arch/ppc/qemu/methods.c Sat Oct 16 19:36:22 2010 (r909) @@ -30,7 +30,7 @@ /* RTAS (run-time abstraction services) */ /************************************************************************/ -#ifdef USE_RTAS +#ifdef CONFIG_RTAS DECLARE_NODE( rtas, INSTALL_OPEN, 0, "+/rtas" ); /* ( physbase -- rtas_callback ) */ @@ -303,7 +303,7 @@ node_methods_init( const char *cpuname ) { phandle_t chosen, ph; -#ifdef USE_RTAS +#ifdef CONFIG_RTAS REGISTER_NODE( rtas ); #endif REGISTER_NODE( ciface ); Modified: trunk/openbios-devel/config/examples/ppc_config.xml ============================================================================== --- trunk/openbios-devel/config/examples/ppc_config.xml Sat Oct 16 19:36:18 2010 (r908) +++ trunk/openbios-devel/config/examples/ppc_config.xml Sat Oct 16 19:36:22 2010 (r909) @@ -58,6 +58,7 @@  <option name="CONFIG_LINUXBIOS" type="boolean" value="false"/> + <option name="CONFIG_RTAS" type="boolean" value="false"/>  <option name="CONFIG_DRIVER_PCI" type="boolean" value="true"/>

1 0

[commit] r908 - trunk/openbios-devel/arch/ppc/qemu
by repository service 16 Oct '10

16 Oct '10

Author: blueswirl Date: Sat Oct 16 19:36:18 2010 New Revision: 908 URL: http://tracker.coreboot.org/trac/openbios/changeset/908 Log: ppc: Fix client stack setup The client stack was set up 96 * 64 KiB below the hash table. Should be 96 KiB instead. v2: * Initial. Cc: Alexander Graf <agraf(a)suse.de> Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/arch/ppc/qemu/start.S Modified: trunk/openbios-devel/arch/ppc/qemu/start.S ============================================================================== --- trunk/openbios-devel/arch/ppc/qemu/start.S Sat Oct 16 19:36:15 2010 (r907) +++ trunk/openbios-devel/arch/ppc/qemu/start.S Sat Oct 16 19:36:18 2010 (r908) @@ -379,7 +379,8 @@ addi r8,r8,LO(saved_stack) // save our stack pointer stw r1,0(r8) mfsdr1 r1 - addis r1, r1, -96 + addi r1, r1, -32768 /* - 32 KiB exception stack */ + addis r1, r1, -1 /* - 64 KiB stack */ lis r5,HA(of_client_callback) addi r5,r5,LO(of_client_callback) // r5 = callback li r6,0 // r6 = address of client program arguments (unused)

1 0

[commit] r907 - trunk/openbios-devel/arch/ppc/qemu
by repository service 16 Oct '10

16 Oct '10

Author: blueswirl Date: Sat Oct 16 19:36:15 2010 New Revision: 907 URL: http://tracker.coreboot.org/trac/openbios/changeset/907 Log: ppc: Fix stack setup The exception stack was always set up 64 KiB below the ROM, ignoring hash table alignment. Align the stack pointer appropriately. v2: * Drop buggy distinction based on PVR value since the previous patch unifies alignment. Suggested by Segher Boessenkool. Cc: Alexander Graf <agraf(a)suse.de> Cc: Segher Boessenkool <segher(a)kernel.crashing.org> Signed-off-by: Andreas Färber <andreas.faerber(a)web.de> Signed-off-by: Blue Swirl <blauwirbel(a)gmail.com> Modified: trunk/openbios-devel/arch/ppc/qemu/start.S Modified: trunk/openbios-devel/arch/ppc/qemu/start.S ============================================================================== --- trunk/openbios-devel/arch/ppc/qemu/start.S Sat Oct 16 19:36:12 2010 (r906) +++ trunk/openbios-devel/arch/ppc/qemu/start.S Sat Oct 16 19:36:15 2010 (r907) @@ -334,9 +334,13 @@ addis r1, r3, -16 /* ramsize - 1MB */ - /* setup exception stack */ + /* setup hash table */ addis r1, r1, -1 /* - 64 kB */ + clrrwi r1, r1, 5*4 /* & ~0xfffff */ + + /* setup exception stack */ + mtsprg0 r1 /* setup stack */

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →