Lubomir Rintel (lkundrak(a)v3.sk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10326
-gerrit
commit ead085840f7ca43292ac3660327d1e592693a756
Author: Lubomir Rintel <lkundrak(a)v3.sk>
Date: Wed May 27 22:17:23 2015 +0200
i82801: protect serial port in DLPC superio too
Change-Id: I6de2fbbc269fb070e56aa37c6e4e1c296fcbc1ec
Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk>
---
SerialICE/simba/chipset/i82801.lua | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/SerialICE/simba/chipset/i82801.lua b/SerialICE/simba/chipset/i82801.lua
index 40be0f9..e27509c 100644
--- a/SerialICE/simba/chipset/i82801.lua
+++ b/SerialICE/simba/chipset/i82801.lua
@@ -166,7 +166,10 @@ function enable_gx_lpc_bars()
pci_cfg32_hook(dev_power, 0x84, "LPC", lpc_io_bar)
pci_cfg32_hook(dev_power, 0x88, "LPC", lpc_io_bar)
- pci_cfg32_hook(dev_power, 0x8c, "LPC", lpc_io_bar)
+ -- The GPIO range 0x1680-0x169f is forwarded to DLPC via this DRR.
+ -- We want our own hook for that range so that we can mask out D_PLTRST
+ -- toggle, ignore it here.
+ pci_cfg32_hook(dev_power, 0x8c, "LPC", lpc_protect_serial_port)
pci_cfg32_hook(dev_power, 0x90, "LPC", lpc_io_bar)
end
Lubomir Rintel (lkundrak(a)v3.sk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10325
-gerrit
commit d22929f77f45fe795f425c6c460850d15816725e
Author: Lubomir Rintel <lkundrak(a)v3.sk>
Date: Mon May 25 07:46:37 2015 +0200
smbus: ignore the least significant f.host.slave bit
It's the transaction direction.
lua: chipset/smbus_host.lua:155: bad argument #2 to 'format' (number has
no integer representation)
stack traceback:
[C]: in function 'string.format'
chipset/smbus_host.lua:155: in upvalue 'dump_transaction'
chipset/smbus_host.lua:271: in upvalue 'host_change_state'
chipset/smbus_host.lua:288: in upvalue 'host_switch'
chipset/smbus_host.lua:368: in upvalue 'host_sync'
chipset/smbus_host.lua:445: in field 'data_read'
chipset/smbus_host.lua:511: in field 'update_register'
chipset/intel_smbus.lua:195: in upvalue 'intel_smbus_host_access'
chipset/intel_smbus.lua:232: in function 'intel_smbus_host_post'
hooks.lua:122: in function 'walk_post_hooks'
replay.lua:24: in function 'replay_io'
replay.lua:76: in function 'parse_io'
replay.lua:250: in function 'parse_file'
replay.lua:269: in main chunk
[C]: in ?
Change-Id: Ia482fc745060c0f84f8147912bf0123d81f3f893
Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk>
---
SerialICE/simba/chipset/smbus_host.lua | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SerialICE/simba/chipset/smbus_host.lua b/SerialICE/simba/chipset/smbus_host.lua
index f8baf2e..13049cc 100644
--- a/SerialICE/simba/chipset/smbus_host.lua
+++ b/SerialICE/simba/chipset/smbus_host.lua
@@ -152,7 +152,7 @@ local function dump_transaction(f, action)
end
- local dump = string.format("%02x %s ", f.host.slave / 2, proto_name[f.host.proto])
+ local dump = string.format("%02x %s ", f.host.slave >> 1, proto_name[f.host.proto])
if host_proto(f, SMBUS_QUICK) then
Lubomir Rintel (lkundrak(a)v3.sk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10324
-gerrit
commit f0907b43d60e1dae72e4aa254d17a276803d6703
Author: Lubomir Rintel <lkundrak(a)v3.sk>
Date: Mon May 25 07:17:25 2015 +0200
pc80: fix "number has no integer representation"
For the value of init == 80:
lua: output.lua:6: bad argument #2 to 'format' (number has no integer representation)
stack traceback:
[C]: in function 'string.format'
output.lua:6: in function 'printf'
output.lua:64: in function 'printk'
chipset/pc80.lua:213: in function 'i8254_post'
hooks.lua:122: in function 'walk_post_hooks'
replay.lua:24: in function 'replay_io'
replay.lua:74: in function 'parse_io'
replay.lua:250: in function 'parse_file'
replay.lua:269: in main chunk
[C]: in ?
Change-Id: Iac92f0f378fec3b9dbb93fe4158cb4ffdd3a1f4a
Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk>
---
SerialICE/simba/chipset/pc80.lua | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SerialICE/simba/chipset/pc80.lua b/SerialICE/simba/chipset/pc80.lua
index 454bdda..a1e3fdc 100644
--- a/SerialICE/simba/chipset/pc80.lua
+++ b/SerialICE/simba/chipset/pc80.lua
@@ -210,7 +210,7 @@ function i8254_post(f, action)
elseif reg == 2 then
if period ~= 0 then
local spktone = 1193000 / f.counter[reg].init
- printk(f, action, "Speaker Tone (%s): %d kHz\n", modestr, spktone)
+ printk(f, action, "Speaker Tone (%s): %f kHz\n", modestr, spktone)
end
end
else