Porting to new boards

[Myles Watson]

I'd like to have SerialICE working on my Tyan boards, but I don't see
any output from the serial port after my porting attempt.

I took a step back and tried Qemu and SimNOW.  I see the SerialICE
prompt, but I don't know how to test that interface.

SerialICE v1.5 (Jun 21 2010)
>

I was expecting to be able to enter some commands at the prompt, to
read/write memory locations and registers.

I'm attaching the patches I am working with:
emulators.diff: Add trivial support for qemu and copy support for
SimNOW from Tyan s2912 since they use the same SuperIO chip.
pci_read.diff: Add pci_read functions, since my Tyan s2895 Serial init
code uses them (copied from Coreboot)
tyan.diff: Add code for s2895 (s2892 is just a copy of s2895 right now)
debug_romstrap.diff: Make the romstrap end up looking like Coreboot's romstrap.

Status:
Qemu & SimNOW give me a prompt, but I don't know how to interact with it.
Tyan s2895 - No output.

Signed-off-by: Myles Watson

Thanks,
Myles

[Joseph Smith]

On 06/21/2010 01:00 PM, Myles Watson wrote:
> I'd like to have SerialICE working on my Tyan boards, but I don't see
> any output from the serial port after my porting attempt.
>
> I took a step back and tried Qemu and SimNOW.  I see the SerialICE
> prompt, but I don't know how to test that interface.
>
> SerialICE v1.5 (Jun 21 2010)

not sure what you mean test it? Have you read the README's? If your 
getting the prompt your good to go :-)
> >
>
> I was expecting to be able to enter some commands at the prompt, to
> read/write memory locations and registers.

yes, why can't you?
> I'm attaching the patches I am working with:
> emulators.diff: Add trivial support for qemu and copy support for
> SimNOW from Tyan s2912 since they use the same SuperIO chip.
> pci_read.diff: Add pci_read functions, since my Tyan s2895 Serial init
> code uses them (copied from Coreboot)
> tyan.diff: Add code for s2895 (s2892 is just a copy of s2895 right now)
> debug_romstrap.diff: Make the romstrap end up looking like Coreboot's romstrap.
>
> Status:
> Qemu&  SimNOW give me a prompt, but I don't know how to interact with it.
> Tyan s2895 - No output.

what is the superio on your s2895?

[Myles Watson]

> On 06/21/2010 01:00 PM, Myles Watson wrote:
> > I'd like to have SerialICE working on my Tyan boards, but I don't see
> > any output from the serial port after my porting attempt.
> >
> > I took a step back and tried Qemu and SimNOW.  I see the SerialICE
> > prompt, but I don't know how to test that interface.
> >
> > SerialICE v1.5 (Jun 21 2010)
>
> not sure what you mean test it? Have you read the README's? If your
> getting the prompt your good to go :-)

I have, but it's always possible that I missed something.
> > I was expecting to be able to enter some commands at the prompt, to
> > read/write memory locations and registers.
>
> yes, why can't you?

I figured it out a little better since then.  I wasn't getting any response
to my queries.  Now I can do reads and writes from the prompt.
> > I'm attaching the patches I am working with:
> > emulators.diff: Add trivial support for qemu and copy support for
> > SimNOW from Tyan s2912 since they use the same SuperIO chip.
> > pci_read.diff: Add pci_read functions, since my Tyan s2895 Serial init
> > code uses them (copied from Coreboot)
> > tyan.diff: Add code for s2895 (s2892 is just a copy of s2895 right now)
> > debug_romstrap.diff: Make the romstrap end up looking like Coreboot's
>
> romstrap.
> > Status:
> > Qemu&  SimNOW give me a prompt, but I don't know how to interact with
>
> it.
> > Tyan s2895 - No output.
>
> what is the superio on your s2895?

smsc lpc47b397.  I copied the initialization code from Coreboot.

Thanks,
Myles

[Stefan Reinauer]

On 6/22/10 6:23 AM, Myles Watson wrote:
> > On 06/21/2010 01:00 PM, Myles Watson wrote:
> > > I'd like to have SerialICE working on my Tyan boards, but I don't see
> > > any output from the serial port after my porting attempt.
> > >
> > > I took a step back and tried Qemu and SimNOW.  I see the SerialICE
> > > prompt, but I don't know how to test that interface.
> > >
> > > SerialICE v1.5 (Jun 21 2010)
> >
> > not sure what you mean test it? Have you read the README's? If your
> > getting the prompt your good to go :-)
>
> I have, but it's always possible that I missed something.
> > > I was expecting to be able to enter some commands at the prompt, to
> > > read/write memory locations and registers.
> >
> > yes, why can't you?
>
> I figured it out a little better since then.  I wasn't getting any response
> to my queries.  Now I can do reads and writes from the prompt.
> > > I'm attaching the patches I am working with:
> > > emulators.diff: Add trivial support for qemu and copy support for
> > > SimNOW from Tyan s2912 since they use the same SuperIO chip.
> > > pci_read.diff: Add pci_read functions, since my Tyan s2895 Serial init
> > > code uses them (copied from Coreboot)
> > > tyan.diff: Add code for s2895 (s2892 is just a copy of s2895 right now)
> > > debug_romstrap.diff: Make the romstrap end up looking like Coreboot's
> >
> > romstrap.
> > > Status:
> > > Qemu&  SimNOW give me a prompt, but I don't know how to interact with
> >
> > it.
> > > Tyan s2895 - No output.
> >
> > what is the superio on your s2895?
>
> smsc lpc47b397.  I copied the initialization code from Coreboot.

You might also need to set up certain parts of the southbridge (worst
case HT enumeration?)

Stefan

[Myles Watson]

> > > > Tyan s2895 - No output.
> > >
> > > what is the superio on your s2895?
> >
> > smsc lpc47b397.  I copied the initialization code from Coreboot.
>
> You might also need to set up certain parts of the southbridge (worst
> case HT enumeration?)

I'll look again.  I thought I'd be safe if I copied the early initialization
up to console init.  I'd figured that the romstrap was wrong, but even after
changing it to match Coreboot I'm not getting anything.

Thanks,
Myles

[Joseph Smith]

On 06/22/2010 09:59 AM, Myles Watson wrote:
> > > > > Tyan s2895 - No output.
> > > >
> > > > what is the superio on your s2895?
> > >
> > > smsc lpc47b397.  I copied the initialization code from Coreboot.
> >
> > You might also need to set up certain parts of the southbridge (worst
> > case HT enumeration?)
>
> I'll look again.  I thought I'd be safe if I copied the early initialization
> up to console init.  I'd figured that the romstrap was wrong, but even after
> changing it to match Coreboot I'm not getting anything.

Has s2895 always used CAR? If not you could go back to a revision that 
used romcc and see how that was setup. Maybe?

[Myles Watson]

> > I'll look again.  I thought I'd be safe if I copied the early
> > initialization
> > up to console init.  I'd figured that the romstrap was wrong, but even
> > after
> > changing it to match Coreboot I'm not getting anything.

It works now.
> Has s2895 always used CAR? If not you could go back to a revision that used
> romcc and see how that was setup. Maybe?

Good suggestion.  This all gets set up before CAR, so I just had to go
back and find what I'd missed.

alive.diff: Fix a minor spelling error.
emulators.diff: Support qemu and SimNOW K8
pci_read.diff: Add pci_read functions so that the Tyan setup works
tyan.diff: Add support for Tyan s2895 and s2892

All boot tested.

Signed-off-by: Myles Watson

Thanks,
Myles

[Joseph Smith]

On 06/22/2010 04:06 PM, Myles Watson wrote:
> > > I'll look again.  I thought I'd be safe if I copied the early
> > > initialization
> > > up to console init.  I'd figured that the romstrap was wrong, but even
> > > after
> > > changing it to match Coreboot I'm not getting anything.
>
> It works now.
> > Has s2895 always used CAR? If not you could go back to a revision that used
> > romcc and see how that was setup. Maybe?
>
> Good suggestion.  This all gets set up before CAR, so I just had to go
> back and find what I'd missed.
>
> alive.diff: Fix a minor spelling error.
> emulators.diff: Support qemu and SimNOW K8
> pci_read.diff: Add pci_read functions so that the Tyan setup works
> tyan.diff: Add support for Tyan s2895 and s2892
>
> All boot tested.

Cool! just curious, so what was it?

[Myles Watson]

> > All boot tested.
>
> Cool! just curious, so what was it?

This function gets called twice.

+	smsc_enable_serial(SUPERIO_CONFIG_PORT, LPC47B397_RT,
SUPERIO_GPIO_IO_BASE);
...
+	smsc_enable_serial(SUPERIO_CONFIG_PORT, LPC47B397_SP1,
CONFIG_SERIAL_PORT);

I didn't notice that, and figured I was done after the call to
enable_serial.  It should probably be renamed to enable_func or something,
but it's working now.

Thanks,
Myles

[Stefan Reinauer]

On 6/22/10 10:06 PM, Myles Watson wrote:
> > > I'll look again.  I thought I'd be safe if I copied the early
> > > initialization
> > > up to console init.  I'd figured that the romstrap was wrong, but even
> > > after
> > > changing it to match Coreboot I'm not getting anything.
>
> It works now.

Oops. I committed the wrong set of patches. Will have to look at the
differences later.

Also, your debug-romstrap patch is still missing. is it needed?

Stefan