the following patch was just integrated into master: commit db2e85d5f4db03c2d2bc49fc4dfacecdae16fb27 Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Tue Mar 12 00:18:13 2013 +0200
Fix SMBus parser
If no SMBus device responds to an address (a NAK condition), the parser state machine did not log the transaction immediately. Once it did log it, the transaction already contained a different SMbus address.
Bad output: 03ac.03b0 .H.. [0000:fff87a30] i801-smbus: 50 byte_data 02 => 08 0000.0000 .... [0000:fff87a01] i801-smbus: 52 byte_data 02 => 00 (TIMEOUT) 04bb.04be .H.. [0000:fff87a30] i801-smbus: 52 byte_data 02 => 08
Correct output: 03ac.03b0 .H.. [0000:fff87a30] i801-smbus: 50 byte_data 02 => 08 0465.0466 .H.. [0000:fff87a18] i801-smbus: 51 byte_data 02 => xx (TIMEOUT) 04bb.04be .H.. [0000:fff87a30] i801-smbus: 52 byte_data 02 => 08
Change-Id: I1ba5be04e7c16267c657bc612220adf9ea6e5673 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: http://review.coreboot.org/2703 Tested-by: build bot (Jenkins) Reviewed-by: Idwer Vollering vidwer@gmail.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org
Build-Tested: build bot (Jenkins) at Wed Mar 13 10:19:11 2013, giving +1 Reviewed-By: Stefan Reinauer stefan.reinauer@coreboot.org at Fri Mar 15 17:07:56 2013, giving +2 See http://review.coreboot.org/2703 for details.
-gerrit