SerialICE April 2016

serialice@serialice.com

1 participants
13 discussions

New patch to review for serialice: qemu-0.15.x/serialice-com: Add ECHO_MODE define
by Patrick Rudolph 25 Apr '16

25 Apr '16

Patrick Rudolph (siro(a)das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14509 -gerrit commit 8f17999d9e14e9fc86cf108f9399f7a07db9393d Author: Patrick Rudolph <siro(a)das-labor.org> Date: Mon Apr 25 12:21:03 2016 +0200 qemu-0.15.x/serialice-com: Add ECHO_MODE define Serialice has this define too. Make sure not to wait for remote echo if it never sends an echo character. Fixes a problem where qemu is waiting forever to receive an echo character. Change-Id: I8d8fce350c63b3e38ee02589cd1564aea95e50bd Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- qemu-0.15.x/serialice-com.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/qemu-0.15.x/serialice-com.c b/qemu-0.15.x/serialice-com.c index 470c76a..54f293b 100644 --- a/qemu-0.15.x/serialice-com.c +++ b/qemu-0.15.x/serialice-com.c @@ -106,6 +106,7 @@ static int serialice_read(SerialICEState * state, void *buf, size_t nbyte) return bytes_read; } +#ifdef ECHO_MODE static int serialice_write(SerialICEState * state, const void *buf, size_t nbyte) { @@ -134,6 +135,36 @@ static int serialice_write(SerialICEState * state, const void *buf, return nbyte; } +#else +static int serialice_write(SerialICEState * state, const void *buf, + size_t nbyte) +{ + char *buffer = (char *)buf; + int ret = 0; + +#ifdef WIN32 + while (nbyte && ret == 0) { + WriteFile(state->fd, buffer, nbyte, &ret, NULL); + if (ret > 0) { + nbyte -= ret; + buffer += ret; + ret = 0; + } + } +#else + while ((ret = write(state->fd, buffer, nbyte)) != nbyte) { + if (ret == -1) { + return -1; + } else if (ret > 0) { + nbyte -= ret; + buffer += ret; + } + } +#endif + + return nbyte; +} +#endif static int serialice_wait_prompt(void) {

1 0

New patch to review for serialice: qemu-0.15.x/serialice-com: Return errors in read function
by Patrick Rudolph 25 Apr '16

25 Apr '16

Patrick Rudolph (siro(a)das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14508 -gerrit commit 8dfcb598b22f89115624c679f5b4522699db5101 Author: Patrick Rudolph <siro(a)das-labor.org> Date: Mon Apr 25 12:19:39 2016 +0200 qemu-0.15.x/serialice-com: Return errors in read function On error return -1 to calling function. Allows calling function to handle errors. Change-Id: I168093eaad897f2998c055e46acd88fe6a263947 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- qemu-0.15.x/serialice-com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-0.15.x/serialice-com.c b/qemu-0.15.x/serialice-com.c index ee539f4..470c76a 100644 --- a/qemu-0.15.x/serialice-com.c +++ b/qemu-0.15.x/serialice-com.c @@ -91,7 +91,7 @@ static int serialice_read(SerialICEState * state, void *buf, size_t nbyte) } if (ret == -1) { - break; + return -1; } #endif

1 0

New patch to review for serialice: qemu-0.15.x/serialice: Fix compilation warnings
by Patrick Rudolph 25 Apr '16

25 Apr '16

Patrick Rudolph (siro(a)das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14507 -gerrit commit 45e35a142945325d309f71074a5a1d747c419d57 Author: Patrick Rudolph <siro(a)das-labor.org> Date: Mon Apr 25 12:17:55 2016 +0200 qemu-0.15.x/serialice: Fix compilation warnings Include the required header to fix compiler warnings. Change-Id: I39085719ca81fb4592138fc254ada6caaecb2fc7 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- qemu-0.15.x/serialice.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-0.15.x/serialice.c b/qemu-0.15.x/serialice.c index 398f378..793951f 100644 --- a/qemu-0.15.x/serialice.c +++ b/qemu-0.15.x/serialice.c @@ -35,6 +35,7 @@ /* Local includes */ #include "hw/hw.h" +#include "cpu.h" #include "hw/loader.h" #include "hw/pc.h" #include "hw/boards.h"

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

SerialICE April 2016