[coreboot-gerrit] Change in coreboot[master]: driver/intel/fsp2_0: Add weak functions for fsp param initialization

Rizwan Qureshi (Code Review) gerrit at coreboot.org
Tue Sep 18 19:36:21 CEST 2018


Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/28660


Change subject: driver/intel/fsp2_0: Add weak functions for fsp param initialization
......................................................................

driver/intel/fsp2_0: Add weak functions for fsp param initialization

Add weak functions for callbacks that should be implementted by SoC.
This loosens the contraint on the SoC for implementing these.
This helps with building platforms without requiring the full FSP upd
header files e.g., SoCs for which FSP is still under development.
The header files can only contain architectural FSP structures excluding
the SoC related structures.

Change-Id: I5ecf1d5e16b8478394975e369e1006e218890655
Signed-off-by: Rizwan Qureshi <rizwan.qureshi at intel.com>
---
M src/drivers/intel/fsp2_0/memory_init.c
M src/drivers/intel/fsp2_0/silicon_init.c
2 files changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/28660/1

diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c
index accb70b..ba7413e 100644
--- a/src/drivers/intel/fsp2_0/memory_init.c
+++ b/src/drivers/intel/fsp2_0/memory_init.c
@@ -411,3 +411,9 @@
 
 	do_fsp_memory_init(&hdr, s3wake, &memmap);
 }
+
+__weak void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd,
+							uint32_t version)
+{
+	/* Do Nothing */
+}
diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c
index 0461b68..b51ff43 100644
--- a/src/drivers/intel/fsp2_0/silicon_init.c
+++ b/src/drivers/intel/fsp2_0/silicon_init.c
@@ -127,3 +127,8 @@
 	fsps_load(s3wake);
 	do_silicon_init(&fsps_hdr);
 }
+
+__weak void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
+{
+	/* Do Nothing */
+}

-- 
To view, visit https://review.coreboot.org/28660
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ecf1d5e16b8478394975e369e1006e218890655
Gerrit-Change-Number: 28660
Gerrit-PatchSet: 1
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180918/a9bcb8ae/attachment-0001.html>


More information about the coreboot-gerrit mailing list