[coreboot-gerrit] Change in coreboot[master]: src/lib/edid: avoid buffer overflow

Julius Werner (Code Review) gerrit at coreboot.org
Tue Sep 18 22:06:22 CEST 2018


Julius Werner has posted comments on this change. ( https://review.coreboot.org/28659 )

Change subject: src/lib/edid: avoid buffer overflow
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28659/1/src/lib/edid.c
File src/lib/edid.c:

https://review.coreboot.org/#/c/28659/1/src/lib/edid.c@178
PS1, Line 178:  + 1
> because the type it's put in (ascii_string in edid.h) is defined the same way.
Oh it just relies on the last byte always staying '\0'. I see.



-- 
To view, visit https://review.coreboot.org/28659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3934bd6965318cdffe5c636b01b3e0c4426e8d1d
Gerrit-Change-Number: 28659
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Sep 2018 20:06:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180918/3368a52c/attachment.html>


More information about the coreboot-gerrit mailing list