<p>Rizwan Qureshi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28660">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">driver/intel/fsp2_0: Add weak functions for fsp param initialization<br><br>Add weak functions for callbacks that should be implementted by SoC.<br>This loosens the contraint on the SoC for implementing these.<br>This helps with building platforms without requiring the full FSP upd<br>header files e.g., SoCs for which FSP is still under development.<br>The header files can only contain architectural FSP structures excluding<br>the SoC related structures.<br><br>Change-Id: I5ecf1d5e16b8478394975e369e1006e218890655<br>Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com><br>---<br>M src/drivers/intel/fsp2_0/memory_init.c<br>M src/drivers/intel/fsp2_0/silicon_init.c<br>2 files changed, 11 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/28660/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c</span><br><span>index accb70b..ba7413e 100644</span><br><span>--- a/src/drivers/intel/fsp2_0/memory_init.c</span><br><span>+++ b/src/drivers/intel/fsp2_0/memory_init.c</span><br><span>@@ -411,3 +411,9 @@</span><br><span> </span><br><span>      do_fsp_memory_init(&hdr, s3wake, &memmap);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+__weak void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                     uint32_t version)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  /* Do Nothing */</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>index 0461b68..b51ff43 100644</span><br><span>--- a/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>+++ b/src/drivers/intel/fsp2_0/silicon_init.c</span><br><span>@@ -127,3 +127,8 @@</span><br><span>   fsps_load(s3wake);</span><br><span>   do_silicon_init(&fsps_hdr);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+__weak void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+    /* Do Nothing */</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28660">change 28660</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28660"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5ecf1d5e16b8478394975e369e1006e218890655 </div>
<div style="display:none"> Gerrit-Change-Number: 28660 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>