[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Convert hex definitions to lower case

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/29009 )

Change subject: amd/stoneyridge: Convert hex definitions to lower case
......................................................................


Patch Set 1:

(2 comments)

A couple of comments unrelated to this change.

https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbdebug.c
File src/soc/amd/stoneyridge/enable_usbdebug.c:

https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbdebug.c@32
PS1, Line 32: 		return PCI_DEV(0, 0x16, 0);
            : 	else if (hcd_idx == 2)
            : 		return PCI_DEV(0, 0x13, 0);
I don't think these two exist on stoney.


https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbdebug.c@36
PS1, Line 36: PCI_DEV(0, 0x12, 0)
SOC_EHCI1_DEV



-- 
To view, visit https://review.coreboot.org/29009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4531e6dad0362be73499647d9fc93c168b6f163e
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 15:13:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181012/6c001d82/attachment.html>