<p style="white-space: pre-wrap; word-wrap: break-word;">A couple of comments unrelated to this change.</p><p><a href="https://review.coreboot.org/29009">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbdebug.c">File src/soc/amd/stoneyridge/enable_usbdebug.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbdebug.c@32">Patch Set #1, Line 32:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                return PCI_DEV(0, 0x16, 0);<br>   else if (hcd_idx == 2)<br>                return PCI_DEV(0, 0x13, 0);<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think these two exist on stoney.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbdebug.c@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace">PCI_DEV(0, 0x12, 0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">SOC_EHCI1_DEV</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/29009">change 29009</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/29009"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I4531e6dad0362be73499647d9fc93c168b6f163e </div>
<div style="display:none"> Gerrit-Change-Number: 29009 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 12 Oct 2018 15:13:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>