[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Convert hex definitions to lower case

Marshall Dawson (Code Review) gerrit at coreboot.org
Thu Oct 11 17:16:48 CEST 2018


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/29009 )

Change subject: amd/stoneyridge: Convert hex definitions to lower case
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge.c@593
PS1, Line 593: cfg5 |= (0x2 << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT) & CG1PLL_SS_AMOUNT_NFRAC_SLIP_MA
> I saw you fixed on a separate patch.
Right.  If I fixed it here, it would be an unrelated change.



-- 
To view, visit https://review.coreboot.org/29009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4531e6dad0362be73499647d9fc93c168b6f163e
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 15:16:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181011/ea4132a6/attachment.html>


More information about the coreboot-gerrit mailing list