[coreboot-gerrit] Change in ...coreboot[master]: {broadcom/cygnus, intel/braswell}: Use DEVICE_NOOP

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29857


Change subject: {broadcom/cygnus,intel/braswell}: Use DEVICE_NOOP
......................................................................

{broadcom/cygnus,intel/braswell}: Use DEVICE_NOOP

Use already defined DEVICE_NOOP instead.

Change-Id: Ie6182f273cba3073c84a502c34a002dee6122c2f
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/soc/broadcom/cygnus/soc.c
M src/soc/intel/braswell/chip.c
2 files changed, 6 insertions(+), 12 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/29857/1

diff --git a/src/soc/broadcom/cygnus/soc.c b/src/soc/broadcom/cygnus/soc.c
index 090d122..1e47f69 100644
--- a/src/soc/broadcom/cygnus/soc.c
+++ b/src/soc/broadcom/cygnus/soc.c
@@ -26,14 +26,10 @@
 	usb_init();
 }
 
-static void soc_noop(struct device *dev)
-{
-}
-
 static struct device_operations soc_ops = {
-	.read_resources   = soc_noop,
-	.set_resources    = soc_noop,
-	.enable_resources = soc_noop,
+	.read_resources   = DEVICE_NOOP,
+	.set_resources    = DEVICE_NOOP,
+	.enable_resources = DEVICE_NOOP,
 	.init             = soc_init,
 	.scan_bus         = 0,
 };
diff --git a/src/soc/intel/braswell/chip.c b/src/soc/intel/braswell/chip.c
index ccd6c9f..6575305 100644
--- a/src/soc/intel/braswell/chip.c
+++ b/src/soc/intel/braswell/chip.c
@@ -37,12 +37,10 @@
 	.scan_bus         = pci_domain_scan_bus,
 };
 
-static void cpu_bus_noop(struct device *dev) { }
-
 static struct device_operations cpu_bus_ops = {
-	.read_resources   = cpu_bus_noop,
-	.set_resources    = cpu_bus_noop,
-	.enable_resources = cpu_bus_noop,
+	.read_resources   = DEVICE_NOOP,
+	.set_resources    = DEVICE_NOOP,
+	.enable_resources = DEVICE_NOOP,
 	.init             = soc_init_cpus
 };
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29857
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6182f273cba3073c84a502c34a002dee6122c2f
Gerrit-Change-Number: 29857
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/bc3d1b32/attachment.html>