[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/{baytrail, broadwell}: Correct Chromeos RAM reservation

Frans Hendriks (Code Review) gerrit at coreboot.org
Tue Nov 27 10:40:16 CET 2018


Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29856


Change subject: soc/intel/{baytrail,broadwell}: Correct Chromeos RAM reservation
......................................................................

soc/intel/{baytrail,broadwell}: Correct Chromeos RAM reservation

RAM is reserved for Chromeos even when Chrome is not used.
Use CONFIG_CHROMEOS to determine is RAM must be reserved.

BUG=N/A
TEST=Intel BayTrail CRB

Change-Id: Ic1f5089227f802e2b2f62dc02fa0d1648c1855b5
Signed-off-by: Frans Hendriks <fhendriks at eltan.com>
---
M src/soc/intel/baytrail/northcluster.c
M src/soc/intel/broadwell/systemagent.c
2 files changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/29856/1

diff --git a/src/soc/intel/baytrail/northcluster.c b/src/soc/intel/baytrail/northcluster.c
index 8271746..0869c7b 100644
--- a/src/soc/intel/baytrail/northcluster.c
+++ b/src/soc/intel/baytrail/northcluster.c
@@ -131,7 +131,8 @@
 	reserved_ram_resource(dev, index++, (0xc0000 >> 10),
 	                      (0x100000 - 0xc0000) >> 10);
 
-	chromeos_reserve_ram_oops(dev, index++);
+	if (IS_ENABLED(CONFIG_CHROMEOS))
+		chromeos_reserve_ram_oops(dev, index++);
 }
 
 static struct device_operations nc_ops = {
diff --git a/src/soc/intel/broadwell/systemagent.c b/src/soc/intel/broadwell/systemagent.c
index 7147750..8013979 100644
--- a/src/soc/intel/broadwell/systemagent.c
+++ b/src/soc/intel/broadwell/systemagent.c
@@ -372,7 +372,8 @@
 	reserved_ram_resource(dev, index++, (0xc0000 >> 10),
 				(0x100000 - 0xc0000) >> 10);
 
-	chromeos_reserve_ram_oops(dev, index++);
+	if (IS_ENABLED(CONFIG_CHROMEOS))
+		chromeos_reserve_ram_oops(dev, index++);
 
 	*resource_cnt = index;
 }

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29856
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1f5089227f802e2b2f62dc02fa0d1648c1855b5
Gerrit-Change-Number: 29856
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/66bda191/attachment.html>


More information about the coreboot-gerrit mailing list