<p>HAOUAS Elyes has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/29857">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">{broadcom/cygnus,intel/braswell}: Use DEVICE_NOOP<br><br>Use already defined DEVICE_NOOP instead.<br><br>Change-Id: Ie6182f273cba3073c84a502c34a002dee6122c2f<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/soc/broadcom/cygnus/soc.c<br>M src/soc/intel/braswell/chip.c<br>2 files changed, 6 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/29857/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/broadcom/cygnus/soc.c b/src/soc/broadcom/cygnus/soc.c</span><br><span>index 090d122..1e47f69 100644</span><br><span>--- a/src/soc/broadcom/cygnus/soc.c</span><br><span>+++ b/src/soc/broadcom/cygnus/soc.c</span><br><span>@@ -26,14 +26,10 @@</span><br><span>        usb_init();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void soc_noop(struct device *dev)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static struct device_operations soc_ops = {</span><br><span style="color: hsl(0, 100%, 40%);">-   .read_resources   = soc_noop,</span><br><span style="color: hsl(0, 100%, 40%);">-   .set_resources    = soc_noop,</span><br><span style="color: hsl(0, 100%, 40%);">-   .enable_resources = soc_noop,</span><br><span style="color: hsl(120, 100%, 40%);">+ .read_resources   = DEVICE_NOOP,</span><br><span style="color: hsl(120, 100%, 40%);">+      .set_resources    = DEVICE_NOOP,</span><br><span style="color: hsl(120, 100%, 40%);">+      .enable_resources = DEVICE_NOOP,</span><br><span>     .init             = soc_init,</span><br><span>        .scan_bus         = 0,</span><br><span> };</span><br><span>diff --git a/src/soc/intel/braswell/chip.c b/src/soc/intel/braswell/chip.c</span><br><span>index ccd6c9f..6575305 100644</span><br><span>--- a/src/soc/intel/braswell/chip.c</span><br><span>+++ b/src/soc/intel/braswell/chip.c</span><br><span>@@ -37,12 +37,10 @@</span><br><span>  .scan_bus         = pci_domain_scan_bus,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void cpu_bus_noop(struct device *dev) { }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static struct device_operations cpu_bus_ops = {</span><br><span style="color: hsl(0, 100%, 40%);">-   .read_resources   = cpu_bus_noop,</span><br><span style="color: hsl(0, 100%, 40%);">-       .set_resources    = cpu_bus_noop,</span><br><span style="color: hsl(0, 100%, 40%);">-       .enable_resources = cpu_bus_noop,</span><br><span style="color: hsl(120, 100%, 40%);">+     .read_resources   = DEVICE_NOOP,</span><br><span style="color: hsl(120, 100%, 40%);">+      .set_resources    = DEVICE_NOOP,</span><br><span style="color: hsl(120, 100%, 40%);">+      .enable_resources = DEVICE_NOOP,</span><br><span>     .init             = soc_init_cpus</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/29857">change 29857</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/29857"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie6182f273cba3073c84a502c34a002dee6122c2f </div>
<div style="display:none"> Gerrit-Change-Number: 29857 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>