[coreboot-gerrit] Change in ...coreboot[master]: mb/siemens/mc_{apl1, tcu3}: [test] Fix sizeof on array function

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Tue Nov 27 11:13:31 CET 2018


HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29858


Change subject: mb/siemens/mc_{apl1,tcu3}: [test] Fix sizeof on array function
......................................................................

mb/siemens/mc_{apl1,tcu3}: [test] Fix sizeof on array function

Change-Id: I982a7a9baf22998503da0e94952fbb30124dfe28
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/mainboard/siemens/mc_apl1/romstage.c
M src/mainboard/siemens/mc_tcu3/romstage.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/29858/1

diff --git a/src/mainboard/siemens/mc_apl1/romstage.c b/src/mainboard/siemens/mc_apl1/romstage.c
index 1483636..5dad9d5 100644
--- a/src/mainboard/siemens/mc_apl1/romstage.c
+++ b/src/mainboard/siemens/mc_apl1/romstage.c
@@ -48,7 +48,7 @@
 		return;
 	}
 
-	if (hwilib_get_field(SPD, spd, sizeof(spd)) != sizeof(spd)) {
+	if (hwilib_get_field(SPD, spd, sizeof(*spd)) != sizeof(*spd)) {
 		printk(BIOS_ERR,
 			"SPD not found in HWInfo, use defaults for FSP-M.\n");
 		return;
diff --git a/src/mainboard/siemens/mc_tcu3/romstage.c b/src/mainboard/siemens/mc_tcu3/romstage.c
index 69e7d21..0e28821 100644
--- a/src/mainboard/siemens/mc_tcu3/romstage.c
+++ b/src/mainboard/siemens/mc_tcu3/romstage.c
@@ -177,7 +177,7 @@
 		return;
 	}
 
-	if (hwilib_get_field(SPD, spd, sizeof(spd)) != sizeof(spd)) {
+	if (hwilib_get_field(SPD, spd, sizeof(*spd)) != sizeof(*spd)) {
 		printk(BIOS_ERR,
 			"SPD not found in HWInfo, use defaults for DDR3.\n");
 		return;

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29858
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I982a7a9baf22998503da0e94952fbb30124dfe28
Gerrit-Change-Number: 29858
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181127/ea116039/attachment-0001.html>


More information about the coreboot-gerrit mailing list