[coreboot-gerrit] Change in ...coreboot[master]: mb/siemens/mc_{apl1, tcu3}: [test] Fix sizeof on array function

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29858 )

Change subject: mb/siemens/mc_{apl1,tcu3}: [test] Fix sizeof on array function
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/29858/1/src/mainboard/siemens/mc_apl1/romstage.c 
File src/mainboard/siemens/mc_apl1/romstage.c:

https://review.coreboot.org/#/c/29858/1/src/mainboard/siemens/mc_apl1/romstage.c@51 
PS1, Line 51: if (hwilib_get_field(SPD, spd, sizeof(*spd)) != sizeof(*spd)) {
Hmmm..no clue what you are after.
What I need here is the size of the whole array spd in bytes. And this is what I get with the current code (sizeof(spd)).
Your change would provide the size of the first element of the array which would be 1 byte. And this is not what I need here.
What is your motivation for suggesting this change?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29858
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I982a7a9baf22998503da0e94952fbb30124dfe28
Gerrit-Change-Number: 29858
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 28 Nov 2018 07:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181128/8359ecc4/attachment.html>