[coreboot-gerrit] Change in coreboot[master]: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/27585 )

Change subject: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

some style nits, otherwise LGTM

https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c
File src/cpu/intel/smm/gen1/smmrelocate.c:

https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c@66
PS1, Line 66: have a different msr
that could be understood as "these two differ in MSR" or "these two differ in MSR from everything else", please clarify.


https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c@72
PS1, Line 72: (1 << 3)
are there names for the bits?



-- 
To view, visit https://review.coreboot.org/27585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee8292ab038e58deb8c24745ec1a9b5da8c31a9
Gerrit-Change-Number: 27585
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 24 Jul 2018 11:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180724/d75661ba/attachment.html>