[coreboot-gerrit] Change in coreboot[master]: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27585 )

Change subject: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c
File src/cpu/intel/smm/gen1/smmrelocate.c:

https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c@78
PS2, Line 78: 			      	&& (msr.lo & FEATURE_CONTROL_LOCK_BIT))) {
code indent should use tabs where possible


https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c@78
PS2, Line 78: 			      	&& (msr.lo & FEATURE_CONTROL_LOCK_BIT))) {
please, no space before tabs


https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c@164
PS2, Line 164: 	/* for model_6fx and model_1067x byte [0:11] on smrr_base are reserved */
line over 80 characters


https://review.coreboot.org/#/c/27585/2/src/cpu/intel/smm/gen1/smmrelocate.c@169
PS2, Line 169: 		params->smrr_base.lo = (params->smram_base & rmask) | MTRR_TYPE_WRBACK;
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee8292ab038e58deb8c24745ec1a9b5da8c31a9
Gerrit-Change-Number: 27585
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 24 Jul 2018 17:07:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180724/666ab111/attachment.html>