[coreboot-gerrit] Change in coreboot[master]: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27585 )

Change subject: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c
File src/cpu/intel/smm/gen1/smmrelocate.c:

https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c@72
PS1, Line 72: 		if (!((msr.lo & (1 << 3)) && (msr.lo & (1 <<0)))) {
need consistent spacing around '<<' (ctx:WxV)


https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c@158
PS1, Line 158: 	/* for model_6fx and model_1067x byte [0:11] on smrr_base are reserved */
line over 80 characters


https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c@163
PS1, Line 163: 		params->smrr_base.lo = (params->smram_base & rmask) | MTRR_TYPE_WRBACK;
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee8292ab038e58deb8c24745ec1a9b5da8c31a9
Gerrit-Change-Number: 27585
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 21 Jul 2018 13:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180721/141b4fc0/attachment.html>