<p style="white-space: pre-wrap; word-wrap: break-word;">some style nits, otherwise LGTM</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://review.coreboot.org/27585">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c">File src/cpu/intel/smm/gen1/smmrelocate.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c@66">Patch Set #1, Line 66:</a> <code style="font-family:monospace,monospace">have a different msr</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">that could be understood as "these two differ in MSR" or "these two differ in MSR from everything else", please clarify.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c@72">Patch Set #1, Line 72:</a> <code style="font-family:monospace,monospace">(1 << 3)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">are there names for the bits?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27585">change 27585</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27585"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8ee8292ab038e58deb8c24745ec1a9b5da8c31a9 </div>
<div style="display:none"> Gerrit-Change-Number: 27585 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 24 Jul 2018 11:56:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>