[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Add mainboard resume function

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27486 )

Change subject: mainboard/google/kahlee: Add mainboard resume function
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/mainboard.c
File src/mainboard/google/kahlee/mainboard.c:

https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/mainboard.c@193
PS1, Line 193: #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
Is this needed here or below?


https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h:

https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h@33
PS1, Line 33: #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
Needed?



-- 
To view, visit https://review.coreboot.org/27486
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I808734208bd1ce81428771ea203709b53db56cd3
Gerrit-Change-Number: 27486
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 15 Jul 2018 00:46:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180715/63d25630/attachment.html>