[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Enable backlight in SMI APMC

[Marc Jones (Code Review)]

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27487


Change subject: mainboard/google/kahlee: Enable backlight in SMI APMC
......................................................................

mainboard/google/kahlee: Enable backlight in SMI APMC

Enable the backlight in the OS callback to SMI for APMC. This keeps
the backlight off until the OS is ready to display something.

BUG=b:72694972
TEST=Backlight turns on at ChromeOS splash screen

Change-Id: Idf32b1a3d45971883571a829a5c0c1f8563bb1f7
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/mainboard/google/kahlee/smihandler.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/27487/1

diff --git a/src/mainboard/google/kahlee/smihandler.c b/src/mainboard/google/kahlee/smihandler.c
index 62ba2b0..83757a8 100644
--- a/src/mainboard/google/kahlee/smihandler.c
+++ b/src/mainboard/google/kahlee/smihandler.c
@@ -17,8 +17,10 @@
 #include <arch/acpi.h>
 #include <cpu/x86/smm.h>
 #include <ec/google/chromeec/smm.h>
+#include <gpio.h>
 #include <soc/smi.h>
 #include <variant/ec.h>
+#include <variant/gpio.h>
 
 void mainboard_smi_gpi(u32 gpi_sts)
 {
@@ -39,5 +41,9 @@
 	if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))
 		chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS,
 					MAINBOARD_EC_SMI_EVENTS);
+
+	/* Enable backlight - GPIO active low */
+	gpio_set(GPIO_133, 0);
+
 	return 0;
 }

-- 
To view, visit https://review.coreboot.org/27487
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf32b1a3d45971883571a829a5c0c1f8563bb1f7
Gerrit-Change-Number: 27487
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180714/20a83c49/attachment-0001.html>