<p>Marc Jones has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/27487">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Enable backlight in SMI APMC<br><br>Enable the backlight in the OS callback to SMI for APMC. This keeps<br>the backlight off until the OS is ready to display something.<br><br>BUG=b:72694972<br>TEST=Backlight turns on at ChromeOS splash screen<br><br>Change-Id: Idf32b1a3d45971883571a829a5c0c1f8563bb1f7<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>---<br>M src/mainboard/google/kahlee/smihandler.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/27487/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/smihandler.c b/src/mainboard/google/kahlee/smihandler.c</span><br><span>index 62ba2b0..83757a8 100644</span><br><span>--- a/src/mainboard/google/kahlee/smihandler.c</span><br><span>+++ b/src/mainboard/google/kahlee/smihandler.c</span><br><span>@@ -17,8 +17,10 @@</span><br><span> #include <arch/acpi.h></span><br><span> #include <cpu/x86/smm.h></span><br><span> #include <ec/google/chromeec/smm.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <gpio.h></span><br><span> #include <soc/smi.h></span><br><span> #include <variant/ec.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <variant/gpio.h></span><br><span> </span><br><span> void mainboard_smi_gpi(u32 gpi_sts)</span><br><span> {</span><br><span>@@ -39,5 +41,9 @@</span><br><span>    if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))</span><br><span>           chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS,</span><br><span>                                     MAINBOARD_EC_SMI_EVENTS);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   /* Enable backlight - GPIO active low */</span><br><span style="color: hsl(120, 100%, 40%);">+      gpio_set(GPIO_133, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/27487">change 27487</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27487"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Idf32b1a3d45971883571a829a5c0c1f8563bb1f7 </div>
<div style="display:none"> Gerrit-Change-Number: 27487 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>