[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Add mainboard resume function

Marc Jones (Code Review) gerrit at coreboot.org
Sun Jul 15 01:46:30 CEST 2018


Marc Jones has uploaded this change for review. ( https://review.coreboot.org/27486


Change subject: mainboard/google/kahlee: Add mainboard resume function
......................................................................

mainboard/google/kahlee: Add mainboard resume function

Add the mainboard resume function and __weak variant override.

Change-Id: I808734208bd1ce81428771ea203709b53db56cd3
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/mainboard/google/kahlee/mainboard.c
M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
2 files changed, 17 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/27486/1

diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c
index cf600d2..2efcb20 100644
--- a/src/mainboard/google/kahlee/mainboard.c
+++ b/src/mainboard/google/kahlee/mainboard.c
@@ -190,18 +190,31 @@
 	return variant_get_ehci_oc_map(map);
 }
 
+#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
+void mainboard_suspend_resume(void)
+{
+	variant_mainboard_suspend_resume();
+}
+#endif
+
 struct chip_operations mainboard_ops = {
 	.init = mainboard_init,
 	.enable_dev = kahlee_enable,
 	.final = mainboard_final,
 };
 
-/* Variants may override this function so see definitions in variants/ */
+/* Variants may override these functions so see definitions in variants/ */
 uint8_t __weak variant_board_sku(void)
 {
 	return 0;
 }
 
+#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
+void __weak variant_mainboard_suspend_resume(void)
+{
+}
+#endif
+
 const char *smbios_mainboard_sku(void)
 {
 	static char sku_str[7]; /* sku{0..255} */
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
index 23f9cb0..6e89105 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
@@ -30,5 +30,8 @@
 const struct soc_amd_gpio *variant_early_gpio_table(size_t *size);
 const struct soc_amd_gpio *variant_gpio_table(size_t *size);
 void variant_romstage_entry(int s3_resume);
+#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
+void variant_mainboard_suspend_resume(void);
+#endif
 
 #endif /* __BASEBOARD_VARIANTS_H__ */

-- 
To view, visit https://review.coreboot.org/27486
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I808734208bd1ce81428771ea203709b53db56cd3
Gerrit-Change-Number: 27486
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180714/30fdbba1/attachment.html>


More information about the coreboot-gerrit mailing list