<p><a href="https://review.coreboot.org/27486">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/mainboard.c">File src/mainboard/google/kahlee/mainboard.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/mainboard.c@193">Patch Set #1, Line 193:</a> <code style="font-family:monospace,monospace">#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this needed here or below?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h">File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h@33">Patch Set #1, Line 33:</a> <code style="font-family:monospace,monospace">#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Needed?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27486">change 27486</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27486"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I808734208bd1ce81428771ea203709b53db56cd3 </div>
<div style="display:none"> Gerrit-Change-Number: 27486 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 15 Jul 2018 00:46:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>