[coreboot-gerrit] Change in ...coreboot[master]: Revert "mb/google/poppy/variants/nocturne: Add DMIC properties to ACP...

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30151 )

Change subject: Revert "mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD"
......................................................................

Revert "mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD"

This reverts commit 999b916015ea0558e3821bdb51501b43a60b5ed6.

The DMIC doesn't have an ACPI id. The patch which enables ACPI
device with id DMIC may create conflict in the feature. Also the
ACPI id "DMIC"  doesn't comply with ACPI naming conventions. The
issue for which the patch was introduced, is already addressed in
kernel DMIC driver and the patches are upstreamed in to the Linux
kernel.

Change-Id: I42cb076700dcb5906599471bebfcd5b265b17644
Signed-off-by: Jenny TC <jenny.tc at intel.com>
Reviewed-on: https://review.coreboot.org/c/30151
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Furquan Shaikh <furquan at google.com>
Reviewed-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
2 files changed, 1 insertion(+), 13 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, but someone else must approve
  Nick Vaccaro: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 58c627c..789578f 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -3,7 +3,6 @@
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384
 	select DRIVERS_GENERIC_GPIO_KEYS
-	select DRIVERS_GENERIC_GENERIC
 	select DRIVERS_I2C_GENERIC
 	select DRIVERS_I2C_HID
 	select EC_GOOGLE_CHROMEEC
diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 031c7ff..76b9773 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -468,18 +468,7 @@
 		end # LPC Interface
 		device pci 1f.1 on  end # P2SB
 		device pci 1f.2 on  end # Power Management Controller
-		device pci 1f.3 on
-			chip drivers/generic/generic
-				register "hid" = ""DMIC""
-				register "name" = ""DMIC""
-				register "desc" = ""Generic DMIC""
-				register "property_count" = "1"
-				register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
-				register "property_list[0].name" = ""modeswitch_delay_ms""
-				register "property_list[0].integer" = "35"
-				device generic 0 on end
-			end
-		end # Intel HDA
+		device pci 1f.3 on  end # Intel HDA
 		device pci 1f.4 on  end # SMBus
 		device pci 1f.5 on  end # PCH SPI
 		device pci 1f.6 off end # GbE

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42cb076700dcb5906599471bebfcd5b265b17644
Gerrit-Change-Number: 30151
Gerrit-PatchSet: 2
Gerrit-Owner: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/61f4567b/attachment.html>