[coreboot-gerrit] Change in ...coreboot[master]: Revert "mb/google/poppy/variants/nocturne: Add DMIC properties to ACP...

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30151 )

Change subject: Revert "mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD"
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+2
> 
> Sorry, last request won't work.  We need to merge this CL, then I need to coordinate a firmware updater bundle with the new kernel changes.  I will +2 this change and once it merges, I will start process to get this change into a firmware bundle package, at which point will give the go-ahead and we'll add CQ-DEPEND for the three kernel CLs along with the new CL containing the new firmware updater bundle.

Looking at how the new code in the kernel was written for this change, I think we should be ok with submitting the three kernel changes before this coreboot change has a chance to propagate to a firmware updater bundle.  In any event, we should be safe to submit this change now as what's important is when the firmware updater bundle containing this change is released (and I think all that's important is that the kernel changes and the overlay change merge prior to the fw updater bundle merging).


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30151
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42cb076700dcb5906599471bebfcd5b265b17644
Gerrit-Change-Number: 30151
Gerrit-PatchSet: 1
Gerrit-Owner: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 19 Dec 2018 00:06:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/6987bf24/attachment.html>