[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )

Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................


Patch Set 38:

(11 comments)

https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c 
File src/soc/intel/common/block/cpu/mp_service_ppi.c:

https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@47 
PS38, Line 47: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@64 
PS38, Line 64: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@67 
PS38, Line 67: 	EFI_PROCESSOR_INFORMATION	*ProcessorInfoBuffer
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@92 
PS38, Line 92: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@97 
PS38, Line 97: 	VOID	*ProcedureArgument
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@116 
PS38, Line 116: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@121 
PS38, Line 121: 	VOID	*ProcedureArgument
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@146 
PS38, Line 146: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@157 
PS38, Line 157: 	CONST EFI_PEI_SERVICES	**ignored1,
need consistent spacing around '*' (ctx:WxO)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@161 
PS38, Line 161: 	UINT32	*HealthFlag
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/25634/38/src/soc/intel/common/block/cpu/mp_service_ppi.c@168 
PS38, Line 168: 	CONST EFI_PEI_SERVICES	**PeiServices,
need consistent spacing around '*' (ctx:WxO)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/25634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 38
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Idwer Vollering <vidwer at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich at gmail.com>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: Furquan Shaikh <furquan at google.com>
Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone at intel.com>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:20:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181211/e0e1a42d/attachment.html>