<p>Patrick Georgi <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30151">View Change</a></p><div style="white-space:pre-wrap">Approvals:
build bot (Jenkins): Verified
Furquan Shaikh: Looks good to me, but someone else must approve
Nick Vaccaro: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD"<br><br>This reverts commit 999b916015ea0558e3821bdb51501b43a60b5ed6.<br><br>The DMIC doesn't have an ACPI id. The patch which enables ACPI<br>device with id DMIC may create conflict in the feature. Also the<br>ACPI id "DMIC" doesn't comply with ACPI naming conventions. The<br>issue for which the patch was introduced, is already addressed in<br>kernel DMIC driver and the patches are upstreamed in to the Linux<br>kernel.<br><br>Change-Id: I42cb076700dcb5906599471bebfcd5b265b17644<br>Signed-off-by: Jenny TC <jenny.tc@intel.com><br>Reviewed-on: https://review.coreboot.org/c/30151<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Furquan Shaikh <furquan@google.com><br>Reviewed-by: Nick Vaccaro <nvaccaro@google.com><br>---<br>M src/mainboard/google/poppy/Kconfig<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>2 files changed, 1 insertion(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig</span><br><span>index 58c627c..789578f 100644</span><br><span>--- a/src/mainboard/google/poppy/Kconfig</span><br><span>+++ b/src/mainboard/google/poppy/Kconfig</span><br><span>@@ -3,7 +3,6 @@</span><br><span> def_bool n</span><br><span> select BOARD_ROMSIZE_KB_16384</span><br><span> select DRIVERS_GENERIC_GPIO_KEYS</span><br><span style="color: hsl(0, 100%, 40%);">- select DRIVERS_GENERIC_GENERIC</span><br><span> select DRIVERS_I2C_GENERIC</span><br><span> select DRIVERS_I2C_HID</span><br><span> select EC_GOOGLE_CHROMEEC</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 031c7ff..76b9773 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -468,18 +468,7 @@</span><br><span> end # LPC Interface</span><br><span> device pci 1f.1 on end # P2SB</span><br><span> device pci 1f.2 on end # Power Management Controller</span><br><span style="color: hsl(0, 100%, 40%);">- device pci 1f.3 on</span><br><span style="color: hsl(0, 100%, 40%);">- chip drivers/generic/generic</span><br><span style="color: hsl(0, 100%, 40%);">- register "hid" = ""DMIC""</span><br><span style="color: hsl(0, 100%, 40%);">- register "name" = ""DMIC""</span><br><span style="color: hsl(0, 100%, 40%);">- register "desc" = ""Generic DMIC""</span><br><span style="color: hsl(0, 100%, 40%);">- register "property_count" = "1"</span><br><span style="color: hsl(0, 100%, 40%);">- register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"</span><br><span style="color: hsl(0, 100%, 40%);">- register "property_list[0].name" = ""modeswitch_delay_ms""</span><br><span style="color: hsl(0, 100%, 40%);">- register "property_list[0].integer" = "35"</span><br><span style="color: hsl(0, 100%, 40%);">- device generic 0 on end</span><br><span style="color: hsl(0, 100%, 40%);">- end</span><br><span style="color: hsl(0, 100%, 40%);">- end # Intel HDA</span><br><span style="color: hsl(120, 100%, 40%);">+ device pci 1f.3 on end # Intel HDA</span><br><span> device pci 1f.4 on end # SMBus</span><br><span> device pci 1f.5 on end # PCH SPI</span><br><span> device pci 1f.6 off end # GbE</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30151">change 30151</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30151"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I42cb076700dcb5906599471bebfcd5b265b17644 </div>
<div style="display:none"> Gerrit-Change-Number: 30151 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Jenny Tc <jenny.tc@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenny Tc <jenny.tc@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>