[coreboot-gerrit] Change in coreboot[master]: intel/common/block: Fix issues found by klockwork

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/28060 )

Change subject: intel/common/block: Fix issues found by klockwork
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/cpu/mp_init.c
File src/soc/intel/common/block/cpu/mp_init.c:

https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/cpu/mp_init.c@138
PS2, Line 138: soc_init_cpus(dev->link_list);
wrap it with 
if (dev && dev->link_list)

With the entries we have in devicetree.cb it will not be NULL though


https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/graphics/graphics.c
File src/soc/intel/common/block/graphics/graphics.c:

https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/graphics/graphics.c@43
PS2, Line 43: 	if (!dev->enabled)
if (!dev || !dev->enabled)



-- 
To view, visit https://review.coreboot.org/28060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51
Gerrit-Change-Number: 28060
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: AndreX Andraos <andrex.andraos at intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-CC: Hannah Williams <hannah.williams at intel.com>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Tue, 14 Aug 2018 19:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180814/207e0379/attachment.html>