[coreboot-gerrit] Change in coreboot[master]: intel/common/block: Fix issues found by klockwork

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/28060 )

Change subject: intel/common/block: Fix issues found by klockwork
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> (1 comment)
> 
> > Martin, What tool are you using for this code scan - we're not
>  > getting these "soc issues" flagged, using Klocwork Static Code
>  > Analysis tool?
>  > We are getting different "warnings" in chip.c and gspi.c files.
> 
> These are generated using clang's scan-build tool:
> https://clang-analyzer.llvm.org/scan-build.html
> 
> We also run coverity's stataic analysis on a bi-weekly basis.  That output is here:
> https://scan.coverity.com/projects/coreboot?tab=overview
> That finds still different issues in soc/intel.

I have a feeling that since static.c gets deleted from the emerge build, so KW does not see the dev_root structure and hence we have been getting errors reported for possible NULL access for dev = dev_find_path


-- 
To view, visit https://review.coreboot.org/28060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51
Gerrit-Change-Number: 28060
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: AndreX Andraos <andrex.andraos at intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-CC: Hannah Williams <hannah.williams at intel.com>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Tue, 14 Aug 2018 18:23:50 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180814/30ce7bc5/attachment.html>