<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">(1 comment)</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Martin, What tool are you using for this code scan - we're not<br>getting these "soc issues" flagged, using Klocwork Static Code<br>Analysis tool?<br>We are getting different "warnings" in chip.c and gspi.c files.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">These are generated using clang's scan-build tool:<br>https://clang-analyzer.llvm.org/scan-build.html</p><p style="white-space: pre-wrap; word-wrap: break-word;">We also run coverity's stataic analysis on a bi-weekly basis.  That output is here:<br>https://scan.coverity.com/projects/coreboot?tab=overview<br>That finds still different issues in soc/intel.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I have a feeling that since static.c gets deleted from the emerge build, so KW does not see the dev_root structure and hence we have been getting errors reported for possible NULL access for dev = dev_find_path</p><p><a href="https://review.coreboot.org/28060">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://review.coreboot.org/28060">change 28060</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28060"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 </div>
<div style="display:none"> Gerrit-Change-Number: 28060 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: John Zhao <john.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: AndreX Andraos <andrex.andraos@intel.com> </div>
<div style="display:none"> Gerrit-CC: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-CC: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 14 Aug 2018 18:23:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-HasLabels: No </div>