<p><a href="https://review.coreboot.org/28060">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/cpu/mp_init.c">File src/soc/intel/common/block/cpu/mp_init.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/cpu/mp_init.c@138">Patch Set #2, Line 138:</a> <code style="font-family:monospace,monospace">soc_init_cpus(dev->link_list);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">wrap it with <br>if (dev && dev->link_list)</p><p style="white-space: pre-wrap; word-wrap: break-word;">With the entries we have in devicetree.cb it will not be NULL though</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/graphics/graphics.c">File src/soc/intel/common/block/graphics/graphics.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/graphics/graphics.c@43">Patch Set #2, Line 43:</a> <code style="font-family:monospace,monospace">   if (!dev->enabled)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">if (!dev || !dev->enabled)</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28060">change 28060</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28060"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51 </div>
<div style="display:none"> Gerrit-Change-Number: 28060 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: John Zhao <john.zhao@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: AndreX Andraos <andrex.andraos@intel.com> </div>
<div style="display:none"> Gerrit-CC: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-CC: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 14 Aug 2018 19:47:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>