[coreboot-gerrit] Change in coreboot[master]: intel/common/block: Fix issues found by klockwork

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28060 )

Change subject: intel/common/block: Fix issues found by klockwork
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28060/1/src/soc/intel/common/block/cpu/mp_init.c
File src/soc/intel/common/block/cpu/mp_init.c:

https://review.coreboot.org/#/c/28060/1/src/soc/intel/common/block/cpu/mp_init.c@137
PS1, Line 137: assert
> Looks like CONFIG_FATAL_ASSERTS is on. […]
I agree with Hannah's approach.

I don't understand what you mean by "it looks like CONFIG_FATAL_ASSERTS is on".  It's a kconfig option.  It may be on in your particular config, but that doesn't mean that it's on in all configs.

You *CANNOT* rely on asserts to guard your code in coreboot.



-- 
To view, visit https://review.coreboot.org/28060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51
Gerrit-Change-Number: 28060
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: AndreX Andraos <andrex.andraos at intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-CC: Hannah Williams <hannah.williams at intel.com>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Tue, 14 Aug 2018 21:51:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180814/763ca4f0/attachment.html>