[commit] r2710 - cpu/x86/pc/alex cpu/x86/pc/newton cpu/x86/pc/olpc/via ofw/gui

[repository service]

Author: wmb
Date: Tue Nov 29 01:26:49 2011
New Revision: 2710
URL: http://tracker.coreboot.org/trac/openfirmware/changeset/2710

Log:
Manufacturing test infrastructure - fixed a stack order bug in the automatic layout code.

Modified:
   cpu/x86/pc/alex/testitems.fth
   cpu/x86/pc/newton/testitems.fth
   cpu/x86/pc/olpc/via/mfgtest.fth
   cpu/x86/pc/olpc/via/testitems.fth
   ofw/gui/iconmenu.fth

Modified: cpu/x86/pc/alex/testitems.fth
==============================================================================
--- cpu/x86/pc/alex/testitems.fth	Tue Nov 29 01:26:41 2011	(r2709)
+++ cpu/x86/pc/alex/testitems.fth	Tue Nov 29 01:26:49 2011	(r2710)
@@ -68,7 +68,7 @@
    silent-probe-usb

0 to #mfgtests
-   0 1 set-col-row
+   1 0 set-row-col

" CPU"
    ['] cpu-item      cpu.icon      add-icon

Modified: cpu/x86/pc/newton/testitems.fth
==============================================================================
--- cpu/x86/pc/newton/testitems.fth	Tue Nov 29 01:26:41 2011	(r2709)
+++ cpu/x86/pc/newton/testitems.fth	Tue Nov 29 01:26:49 2011	(r2710)
@@ -32,7 +32,6 @@
 icon: cpu.icon      rom:cpu.565
 icon: spi.icon      rom:spi.565
 icon: ram.icon      rom:ram.565
-icon: sdcard.icon   rom:sdcard.565
 icon: usb.icon      rom:usb.565
 icon: wifi.icon     rom:wifi.565
 icon: audio.icon    rom:audio.565
@@ -62,7 +61,7 @@
    silent-probe-usb

0 to #mfgtests
-   0 1 set-col-row
+   1 0 set-row-col

" CPU"
    ['] cpu-item      cpu.icon      add-icon
@@ -73,9 +72,6 @@
    " RAM chips"
    ['] memory-item   ram.icon      add-icon

-   " Internal mass storage"
-   ['] int-sd-item   sdcard.icon   add-icon
-
    " Timer"
    ['] timer-item    timer.icon    add-icon

Modified: cpu/x86/pc/olpc/via/mfgtest.fth
==============================================================================
--- cpu/x86/pc/olpc/via/mfgtest.fth	Tue Nov 29 01:26:41 2011	(r2709)
+++ cpu/x86/pc/olpc/via/mfgtest.fth	Tue Nov 29 01:26:49 2011	(r2710)
@@ -102,7 +102,7 @@
 0 value cur-row
 : cur-col++  ( -- )  cur-col 1+ to cur-col  ;
 : cur-row++  ( -- )  cur-row 1+ to cur-row  ;
-: set-col-row ( row col -- )  to cur-col  to cur-row  ;
+: set-row-col  ( row col -- )  to cur-col  to cur-row  ;
 : add-icon   ( -- )
    cur-col #mfgcols =  if
       cur-row++  cur-row #mfgcols >=  if  abort" Too many icons"  then

Modified: cpu/x86/pc/olpc/via/testitems.fth
==============================================================================
--- cpu/x86/pc/olpc/via/testitems.fth	Tue Nov 29 01:26:41 2011	(r2709)
+++ cpu/x86/pc/olpc/via/testitems.fth	Tue Nov 29 01:26:49 2011	(r2710)
@@ -40,7 +40,7 @@

: olpc-test-menu-items  ( -- )
    0 to #mfgtests
-   0 1 set-col-row
+   1 0 set-row-col

\   " CPU"
 \   ['] cpu-item      cpu.icon      add-icon

Modified: ofw/gui/iconmenu.fth
==============================================================================
--- ofw/gui/iconmenu.fth	Tue Nov 29 01:26:41 2011	(r2709)
+++ ofw/gui/iconmenu.fth	Tue Nov 29 01:26:49 2011	(r2710)
@@ -118,7 +118,7 @@

: clear-sq  ( sq - )  >r  null$  ['] noop  0  r> set-sq  ;
 headers
-: clear-menu  ( - )  squares 0 do  i clear-sq  loop  ;
+: clear-menu  ( - )  squares 0  ?do  i clear-sq  loop  ;
 headerless

: active?  ( sq - active? )