[commit] r2795 - ofw/core

[repository service]

Author: wmb
Date: Sat Dec 31 23:25:58 2011
New Revision: 2795
URL: http://tracker.coreboot.org/trac/openfirmware/changeset/2795

Log:
OLPC trac #11349 - The generic "$delete1" file command was leaving a directory ihandle open in the case where the file could not be deleted, leading to a delayed action bug that could cause write data not to be flushed from the disk buffer.

Modified:
   ofw/core/filecmds.fth

Modified: ofw/core/filecmds.fth
==============================================================================
--- ofw/core/filecmds.fth	Sat Dec 31 21:53:45 2011	(r2794)
+++ ofw/core/filecmds.fth	Sat Dec 31 23:25:58 2011	(r2795)
@@ -295,8 +295,9 @@

: $delete1  ( path$ -- )
    open-directory ?dup 0= abort" Can't open directory"      ( name$ dir-ih )
-   >r  " $delete!" r@ $call-method  abort" Can't delete file"  ( r: dir-ih ) 
-   r> close-dev   
+   >r  " $delete!" r@ $call-method  ( error?  r: dir-ih ) 
+   r> close-dev                     ( error? )
+   abort" Can't delete file"  
 ;
 ' $delete1 to _ofdelete