[flashrom] [PATCH] ichspi.c: do not print PBR[3] for ICH7 because it does not exist

Stefan Tauner stefan.tauner at student.tuwien.ac.at
Sun Jul 24 00:49:10 CEST 2011


intel document 307013 (ICH7 datasheet) section 21.1.9 does only define
PBR[0] (at SPIBAR + 60h) to PBR[2] (SPIBAR + 68h). SPIBAR + 6Ch and following
are not defined, but we were printing them as PBR[3] anyway. i could not find
any references to PBR[3] in documentation of other related chips (NM10,
atom e6xx) either, hence kill it.

Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
---
 ichspi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ichspi.c b/ichspi.c
index 99c4613..0258626 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -1263,7 +1263,7 @@ int ich_init_spi(struct pci_dev *dev, uint32_t base, void *rcrb,
 			     mmio_readl(ich_spibar + 0x58));
 		msg_pdbg("0x5c: 0x%08x (OPMENU+4)\n",
 			     mmio_readl(ich_spibar + 0x5c));
-		for (i = 0; i < 4; i++) {
+		for (i = 0; i < 3; i++) {
 			int offs;
 			offs = 0x60 + (i * 4);
 			msg_pdbg("0x%02x: 0x%08x (PBR%d)\n", offs,
-- 
1.7.1





More information about the flashrom mailing list