[flashrom] [PATCH] ichspi.c: do not print PBR[3] for ICH7 because it does not exist

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Jul 24 01:18:07 CEST 2011


Am 24.07.2011 00:49 schrieb Stefan Tauner:
> intel document 307013 (ICH7 datasheet) section 21.1.9 does only define
> PBR[0] (at SPIBAR + 60h) to PBR[2] (SPIBAR + 68h). SPIBAR + 6Ch and following
> are not defined, but we were printing them as PBR[3] anyway. i could not find
> any references to PBR[3] in documentation of other related chips (NM10,
> atom e6xx) either, hence kill it.
>
> Signed-off-by: Stefan Tauner <stefan.tauner at student.tuwien.ac.at>
>   

Good spotting.

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list