[flashrom] [PATCH] ICH9/10: display FRAP/FREGx access controls
Joshua Roys
roysjosh at gmail.com
Thu Jul 1 18:50:47 CEST 2010
On 07/01/2010 12:35 PM, Carl-Daniel Hailfinger wrote:
>> + base = ICH_FREG_BASE(freg);
>> + limit = ICH_FREG_LIMIT(freg);
>> + if (base == 0x1fff && limit == 0) {
>> + /* this FREG is disabled */
>> + msg_pdbg("%s region is unused.\n", region_names[i]);
>>
>
> "... unused or has no access restrictions.\n" would be better. I don't
> believe your machine has no BIOS region.
>
>
I would prefer to leave this as-is, per the ich10 datasheet around page 805:
"NOTE: If the BIOS region is not used, the Region Base must be
programmed to 1FFFh and the Region Limit to 0000h to disable the region."
>
> Rest is fine, and will be acked and committed by me.
>
> Regards,
> Carl-Daniel
>
The other suggestions were incorporated. Thanks!
Josh
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-ICH9-10-display-FRAP-FREGx-access-controls.patch
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100701/b0e4382a/attachment.ksh>
More information about the flashrom
mailing list