[flashrom] [PATCH] ICH9/10: display FRAP/FREGx access controls

[Carl-Daniel Hailfinger]

On 01.07.2010 18:50, Joshua Roys wrote:
> On 07/01/2010 12:35 PM, Carl-Daniel Hailfinger wrote:
>   
>>> +	base  = ICH_FREG_BASE(freg);
>>> +	limit = ICH_FREG_LIMIT(freg);
>>> +	if (base == 0x1fff && limit == 0) {
>>> +		/* this FREG is disabled */
>>> +		msg_pdbg("%s region is unused.\n", region_names[i]);
>>>   
>>>       
>> "... unused or has no access restrictions.\n" would be better. I don't
>> believe your machine has no BIOS region.
>>     
>
> I would prefer to leave this as-is, per the ich10 datasheet around page 805:
>
> "NOTE: If the BIOS region is not used, the Region Base must be
> programmed to 1FFFh and the Region Limit to 0000h to disable the region."
>   

Interesting. So it is indeed possible to have flash in descriptor mode
and still have no designated BIOS region? It will be very interesting to
dump the descriptors in the descriptor region.

> ICH9/10: display FRAP/FREGx access controls
>
> Signed-off-by: Joshua Roys <roysjosh at gmail.com>
>   

Thanks for reworking the patch.

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
and committed in r1066.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/