[flashrom] [PATCH] Board enable for Asus P4S800-MX

[David Borg]

>> Index: board_enable.c
>> ===================================================================
>> --- board_enable.c    (revision 1127)
>> +++ board_enable.c    (working copy)
>> @@ -352,7 +352,9 @@
>>  }
>>
>>  /**
>> - * w83627: Enable MEMW# and set ROM size to max.
>> + * Enable MEMW# and set ROM size to max.
>> + * Supported chips:
>> + * W83L517D, W83697HF/F/HG, W83697SF/UF/UG
>>
>
> Is there a reason you removed w83627 from the list?

Yes. A cross check with the datasheets for the following shows that it
is not correct:

W83627DHG
W83627DHG-P
W83627DHG-PT
W83627EEF
W83627EEG
W83627EHF
W83627EHG
W83627F
W83627G
W83627HF
W83627HG
W83627SF
W83627THF
W83627THG
W83627UHG

In addition the function was introduced at revision 490
(http://flashrom.org/trac/flashrom/changeset/490/trunk/board_enable.c),
replacing existing W83697 SuperIO enables.

Motherboards that used the function at that time where:
ASUS A7V8X-MX SE and A7V400-MX, Tyan Tomcat K7M and EPoX EP-8K5A2

A7V8X-MX SE: W83697HF SuperIO
(http://www.mail-archive.com/flashrom@flashrom.org/msg01316.html)

A7V400-MX: W83697HF SuperIO
(http://www.mail-archive.com/linuxbios@linuxbios.org/msg05809.html
Used function W83697_rom_memw_enable, and more importantly, the
following CPU-Z output
http://forum.darkhardware.com/viewtopic.php?f=8&t=158540)

Tomcat K7M: W83697HF SuperIO
(http://tracker.coreboot.org/trac/coreboot/browser/trunk/util/flashrom/board_enable.c?rev=2732,
http://www.macmall.com/p/product~dpno~686101~pdp.dcjggah?source=zwb12166
- under Chipset section)

EP-8K5A2: W83697HF SuperIO
(http://forums.amd.com/forum/messageview.cfm?catid=24&threadid=65550)

The following source code documentation takes care of the other motherboards
/**
 * Winbond W83697HF Super I/O + VIA VT8235 southbridge
 *
 * Suited for:
 *   - MSI KT4V and KT4V-L: AMD K7 + VIA KT400 + VT8235
 *   - MSI KT4 Ultra: AMD K7 + VIA KT400 + VT8235
 */


>
> Second subsystem vendor has one space too few, and second subsystem
> device has one space too many.
>

I'm guessing the combination of ssh + bash + nano isn't too whitespace friendly.

>
> I'll leave the review to Michael or Uwe who know board enables really
> well. Apart from the cosmetic comments above, the board enable looks
> good IMHO.
> We should check if DMI matching is really needed or just excessive caution.
>

Ok.

Thanks for the quick review!

Regards,

David Borg