[flashrom] [PATCH] Board enable for Asus P4S800-MX

[Carl-Daniel Hailfinger]

On 30.07.2010 20:17, David Borg wrote:
> the subsystem ID has been left blank as the PCI bridge has no subsystem ID.
>
> On 30 July 2010 19:42, David Borg <borg.db at gmail.com> wrote:
>   
>> Tested and works. Thanks to Carl-Daniel Hailfinger for simplifying the
>> chipset enable for this board!
>>
>> Signed-off-by: David Borg <borg.db at gmail.com>
>>     
> Index: board_enable.c
> ===================================================================
> --- board_enable.c	(revision 1127)
> +++ board_enable.c	(working copy)
> @@ -352,7 +352,9 @@
>  }
>  
>  /**
> - * w83627: Enable MEMW# and set ROM size to max.
> + * Enable MEMW# and set ROM size to max.
> + * Supported chips:
> + * W83L517D, W83697HF/F/HG, W83697SF/UF/UG
>   

Is there a reason you removed w83627 from the list?


>   */
>  static void w836xx_memw_enable(uint16_t port)
>  {
> @@ -1715,6 +1717,7 @@
>  	{0x8086, 0x24D3, 0x1043, 0x80A6,  0x8086, 0x2578, 0x1043, 0x80F6, NULL,          NULL,         NULL,          "ASUS",        "P4C800-E Deluxe",       0,   OK, intel_ich_gpio21_raise},
>  	{0x8086, 0x2570, 0x1043, 0x80F2,  0x105A, 0x3373, 0x1043, 0x80F5, NULL,          NULL,         NULL,          "ASUS",        "P4P800-E Deluxe",       0,   OK, intel_ich_gpio21_raise},
>  	{0x8086, 0x2570, 0x1043, 0x80A5,  0x105A, 0x24D3, 0x1043, 0x80A6, NULL,          NULL,         NULL,          "ASUS",        "P4SD-LA",               0,   NT, intel_ich_gpio32_raise},
> +	{0x1039, 0x0661, 0x1043, 0x8113,  0x1039, 0x0003,     0,       0, "^P4S800-MX$", NULL,         NULL,          "ASUS",        "P4S800-MX",           512,   OK, w836xx_memw_enable_2e},
>   

Second subsystem vendor has one space too few, and second subsystem
device has one space too many.


>  	{0x10B9, 0x1541,      0,      0,  0x10B9, 0x1533,      0,      0, "^P5A$",       "asus",       "p5a",         "ASUS",        "P5A",                   0,   OK, board_asus_p5a},
>  	{0x10DE, 0x0030, 0x1043, 0x818a,  0x8086, 0x100E, 0x1043, 0x80EE, NULL,          NULL,         NULL,          "ASUS",        "P5ND2-SLI Deluxe",      0,   OK, nvidia_mcp_gpio10_raise},
>  	{0x8086, 0x24dd, 0x1043, 0x80a6,  0x8086, 0x2570, 0x1043, 0x8157, NULL,          NULL,         NULL,          "ASUS",        "P5PE-VM",               0,   OK, intel_ich_gpio21_raise},
>   

I'll leave the review to Michael or Uwe who know board enables really
well. Apart from the cosmetic comments above, the board enable looks
good IMHO.
We should check if DMI matching is really needed or just excessive caution.


Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/