[flashrom] [PATCH] Board enable for Asus P4S800-MX
Michael Karcher
flashrom at mkarcher.dialup.fu-berlin.de
Sun Aug 1 21:44:45 CEST 2010
Am Sonntag, den 01.08.2010, 01:31 +0200 schrieb Carl-Daniel Hailfinger:
> > + {0x1039, 0x0661, 0x1043, 0x8113, 0x1039, 0x0003, 0, 0, "^P4S800-MX$", NULL, NULL, "ASUS", "P4S800-MX", 512, OK, w836xx_memw_enable_2e},
> >
> I'll leave the review to Michael or Uwe who know board enables really
> well. Apart from the cosmetic comments above, the board enable looks
> good IMHO.
> We should check if DMI matching is really needed or just excessive caution.
If you just have one subsystem ID, DMI might be a good idea. I suggested
not to use the IDE controller for the second subsystem ID, as it varies
with AHCI/RAID/whatsoever modes, but this board is so old, it has
nothing of them. I suggest to use the IDE PCI ID with subsystem as
second device and drop the DMI.
Regards,
Michael Karcher
More information about the flashrom
mailing list