[coreboot] Can we please stop hiding semantic changes behind "found by checkpatch" (Re: New Defects reported by Coverity Scan for coreboot)

[Martin Roth]

Hi Nico,
  I think that's a great idea, and I'll see what I can set up.

We can search the commit message for "no functional changes" or
"binary-stable" and then run a build of the previous commit as well as
the current commit, then compare the checksums for each build to make
sure they match.

Martin

On Fri, Mar 24, 2017 at 9:58 AM, Nico Huber <nico.huber at secunet.com> wrote:
> Hi all,
>
> don't get me wrong, I think style fixes are a good thing and appreciate
> that people take the time for it. However, if we do massive changes to
> comply with a tool like checkpatch.pl, we should make sure that single
> commits either change style only, or really fix something which should
> then be mentioned in the commit message.
>
> With many changes in one commit, the former is hard to review but can
> be verified by reproducibility of the binaries beyond the patch. We
> have an option to exclude commit information in the resulting image:
> `make BUILD_TIMELESS=1 what-jenkins-does` should do the trick.
>
> Can we set up a Jenkins job for that? either manually triggered to help
> the reviewer or maybe even automatically by a tag like `BUILD=binary-
> stable`?.
>
> Regards,
> Nico
>
> --
> coreboot mailing list: coreboot at coreboot.org
> https://www.coreboot.org/mailman/listinfo/coreboot