[coreboot] New Defects reported by Coverity Scan for coreboot

scan-admin at coverity.com scan-admin at coverity.com
Tue Mar 28 11:59:25 CEST 2017


Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

13 new defect(s) introduced to coreboot found with Coverity Scan.
481 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 13 of 13 defect(s)


** CID 1373089:  Parse warnings  (PARSE_ERROR)
/tmp/temp.G4RJVF.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373089:  Parse warnings  (PARSE_ERROR)
/tmp/temp.G4RJVF.c: 1 in ()
>>>     CID 1373089:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373088:  Parse warnings  (PARSE_ERROR)
/tmp/temp.B0H6w5.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373088:  Parse warnings  (PARSE_ERROR)
/tmp/temp.B0H6w5.c: 1 in ()
>>>     CID 1373088:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373087:  Parse warnings  (PARSE_ERROR)
/tmp/temp.kpjccO.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373087:  Parse warnings  (PARSE_ERROR)
/tmp/temp.kpjccO.c: 1 in ()
>>>     CID 1373087:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373086:  Parse warnings  (PARSE_ERROR)
/tmp/temp.bOx5yG.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373086:  Parse warnings  (PARSE_ERROR)
/tmp/temp.bOx5yG.c: 1 in ()
>>>     CID 1373086:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373085:  Parse warnings  (PARSE_ERROR)
/tmp/temp.8DKWQb.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373085:  Parse warnings  (PARSE_ERROR)
/tmp/temp.8DKWQb.c: 1 in ()
>>>     CID 1373085:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373084:  Parse warnings  (PARSE_ERROR)
/tmp/temp.3Lg4Jr.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373084:  Parse warnings  (PARSE_ERROR)
/tmp/temp.3Lg4Jr.c: 1 in ()
>>>     CID 1373084:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373083:  Parse warnings  (PARSE_ERROR)
/tmp/temp.NUhGsE.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373083:  Parse warnings  (PARSE_ERROR)
/tmp/temp.NUhGsE.c: 1 in ()
>>>     CID 1373083:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373082:  Parse warnings  (PARSE_ERROR)
/tmp/temp.8J3QKd.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373082:  Parse warnings  (PARSE_ERROR)
/tmp/temp.8J3QKd.c: 1 in ()
>>>     CID 1373082:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373081:  Parse warnings  (PARSE_ERROR)
/tmp/temp.QvRa1H.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373081:  Parse warnings  (PARSE_ERROR)
/tmp/temp.QvRa1H.c: 1 in ()
>>>     CID 1373081:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373080:  Parse warnings  (PARSE_ERROR)
/tmp/temp.sKsjDZ.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373080:  Parse warnings  (PARSE_ERROR)
/tmp/temp.sKsjDZ.c: 1 in ()
>>>     CID 1373080:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373079:  Parse warnings  (PARSE_ERROR)
/tmp/temp.Ns1GBX.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373079:  Parse warnings  (PARSE_ERROR)
/tmp/temp.Ns1GBX.c: 1 in ()
>>>     CID 1373079:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373078:  Parse warnings  (PARSE_ERROR)
/tmp/temp.fMs4K7.c: 1 in ()


________________________________________________________________________________________________________
*** CID 1373078:  Parse warnings  (PARSE_ERROR)
/tmp/temp.fMs4K7.c: 1 in ()
>>>     CID 1373078:  Parse warnings  (PARSE_ERROR)
>>>     The Coverity compiler fails to compile this file. Please see the build output log for more information.

** CID 1373077:    (MIXED_ENUMS)
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 388 in vb2_update_menu()
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 407 in vb2_update_menu()
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 410 in vb2_update_menu()
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 418 in vb2_update_menu()
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 422 in vb2_update_menu()


________________________________________________________________________________________________________
*** CID 1373077:    (MIXED_ENUMS)
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 388 in vb2_update_menu()
382     {
383     	VbError_t ret = VBERROR_SUCCESS;
384     	VB_MENU next_menu_idx = current_menu_idx;
385     	switch(current_menu) {
386     	case VB_MENU_DEV_WARNING:
387     		switch(current_menu_idx) {
>>>     CID 1373077:    (MIXED_ENUMS)
>>>     But this case, "VB_WARN_OPTIONS", is of different type "enum _VB_DEV_WARNING_MENU".
388     		case VB_WARN_OPTIONS:
389     			switch(default_boot) {
390     			case VBNV_DEV_DEFAULT_BOOT_DISK:
391     				next_menu_idx = VB_DEV_DISK;
392     				break;
393     			case VBNV_DEV_DEFAULT_BOOT_USB:
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 407 in vb2_update_menu()
401     			/*
402     			 * 1. Select dev menu
403     			 * 2. Default to dev boot device
404     			 */
405     			vb2_set_menu_items(VB_MENU_DEV, next_menu_idx);
406     			break;
>>>     CID 1373077:    (MIXED_ENUMS)
>>>     But this case, "VB_WARN_DBG_INFO", is of different type "enum _VB_DEV_WARNING_MENU".
407     		case VB_WARN_DBG_INFO:
408     			/* Show debug info */
409     			break;
410     		case VB_WARN_ENABLE_VER:
411     			/*
412     			 * 1. Enable boot verification
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 410 in vb2_update_menu()
404     			 */
405     			vb2_set_menu_items(VB_MENU_DEV, next_menu_idx);
406     			break;
407     		case VB_WARN_DBG_INFO:
408     			/* Show debug info */
409     			break;
>>>     CID 1373077:    (MIXED_ENUMS)
>>>     But this case, "VB_WARN_ENABLE_VER", is of different type "enum _VB_DEV_WARNING_MENU".
410     		case VB_WARN_ENABLE_VER:
411     			/*
412     			 * 1. Enable boot verification
413     			 * 2. Default to the power off option
414     			 */
415     			vb2_set_menu_items(VB_MENU_TO_NORM,
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 418 in vb2_update_menu()
412     			 * 1. Enable boot verification
413     			 * 2. Default to the power off option
414     			 */
415     			vb2_set_menu_items(VB_MENU_TO_NORM,
416     					   VB_TO_NORM_POWER_OFF);
417     			break;
>>>     CID 1373077:    (MIXED_ENUMS)
>>>     But this case, "VB_WARN_POWER_OFF", is of different type "enum _VB_DEV_WARNING_MENU".
418     		case VB_WARN_POWER_OFF:
419     			/* Power off machine */
420     			ret =  VBERROR_SHUTDOWN_REQUESTED;
421     			break;
422     		case VB_WARN_LANGUAGE:
423     			/* Languages */
/3rdparty/vboot/firmware/lib/vboot_ui_menu.c: 422 in vb2_update_menu()
416     					   VB_TO_NORM_POWER_OFF);
417     			break;
418     		case VB_WARN_POWER_OFF:
419     			/* Power off machine */
420     			ret =  VBERROR_SHUTDOWN_REQUESTED;
421     			break;
>>>     CID 1373077:    (MIXED_ENUMS)
>>>     But this case, "VB_WARN_LANGUAGE", is of different type "enum _VB_DEV_WARNING_MENU".
422     		case VB_WARN_LANGUAGE:
423     			/* Languages */
424     			// TODO: we'll have to figure out how to display this
425     			vb2_set_menu_items(VB_MENU_LANGUAGES,
426     					   VB_LANGUAGES_EN_US);
427     			break;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bvtXSnJyin2fyVojE53gftXzVbXcCLlMVt-2FMZRGDzs7IgylveiRN4Mj9ZySgKfUXC0d1w923IV28OQbPm2cV8N-2F-2FCLAw7uoAjfKqGWMoES4xSVu4k60H9vpDQ-2Fp07g5N-2FmJkrRHPcYEGPg-2FcYdiACrUI-2Bing7SDC7HXjMdzGMvQEaOFJVdZVOGlhU6Yw7ffBY-3D

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4e-2BpBzwOa5gzBZa9dWpDbzfofODnVj1enK2UkK0-2BgCCqyeem8IVKvTxSaOFkteZFcnohwvb2rnYNjswGryEWCURnUk6WHU42sbOmtOjD-2Bx5c-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bvtXSnJyin2fyVojE53gft08jPXApad5ytHzXpuSAKi8AWb0wL5hAhkhrJ-2BWmW2yZ-2BmI-2FFQQ5rUY56CuabwKzRCKCYEoQLUmGo8K5U6tW0MAb09faE0TAXkJhaXKIDTXSDMypZ3pbBxMbcYKPJyYFWbOMgi18F3aswjLYPwi8SHwzIJyrVmEShEmEkbWvoPwU-3D




More information about the coreboot mailing list