[coreboot-gerrit] Change in coreboot[master]: sb/intel/common/firmware: Ensure warning is put late

Nico Huber (Code Review) gerrit at coreboot.org
Wed Sep 19 10:10:23 CEST 2018


Nico Huber has uploaded this change for review. ( https://review.coreboot.org/28673


Change subject: sb/intel/common/firmware: Ensure warning is put late
......................................................................

sb/intel/common/firmware: Ensure warning is put late

Change-Id: I400de0a622c2b45ea5ef1f1446f4f489ac397c32
---
M src/southbridge/intel/common/firmware/Makefile.inc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/28673/1

diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.inc
index 01a8061..774bb23 100644
--- a/src/southbridge/intel/common/firmware/Makefile.inc
+++ b/src/southbridge/intel/common/firmware/Makefile.inc
@@ -23,7 +23,7 @@
 ifeq ($(CONFIG_HAVE_IFD_BIN),y)
 INTERMEDIATE+=add_intel_firmware
 else ifeq ($(CONFIG_INTEL_DESCRIPTOR_MODE_REQUIRED),y)
-INTERMEDIATE += warn_intel_firmware
+files_added:: warn_intel_firmware
 endif
 
 IFD_BIN_PATH := $(CONFIG_IFD_BIN_PATH)
@@ -89,7 +89,7 @@
 
 warn_intel_firmware:
 	printf "\n\t** WARNING **\n"
-	printf "coreboot will be built without an Intel Firmware Descriptor.\n"
+	printf "coreboot has been built without an Intel Firmware Descriptor.\n"
 	printf "Never write a complete coreboot.rom without an IFD to your\n"
 	printf "board's flash chip! You can use flashrom's IFD or layout\n"
 	printf "parameters to flash only to the BIOS region.\n\n"

-- 
To view, visit https://review.coreboot.org/28673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I400de0a622c2b45ea5ef1f1446f4f489ac397c32
Gerrit-Change-Number: 28673
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180919/5eef3391/attachment.html>


More information about the coreboot-gerrit mailing list