[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27619 )

Change subject: soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib
......................................................................


Patch Set 10:

(3 comments)

https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/include/amdblocks/psp.h
File src/soc/amd/common/block/include/amdblocks/psp.h:

https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/include/amdblocks/psp.h@35
PS10, Line 35: #define MAGIC_ENABLE_BITS             0x34 /* Extra PCI HDR Ctl Enables     */ 
trailing whitespace


https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c
File src/soc/amd/common/block/psp/psp.c:

https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c@49
PS10, Line 49: 	if (value32 == 0xFFFFFFFF) {
suspect code indent for conditional statements (8, 10)


https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c@56
PS10, Line 56: 	if (pci_read_config32(SOC_PSP_DEV, PCI_BASE_ADDRESS_4) & ~0x0F) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/27619
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2740ceb945736c6e413f7d0bd0c41a19e19c7d5a
Gerrit-Change-Number: 27619
Gerrit-PatchSet: 10
Gerrit-Owner: Charles Marslett <charles.marslett at amd.corp-partner.google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Charles Marslett <charles.marslett at amd.corp-partner.google.com>
Gerrit-Reviewer: Charles Marslett <charles.marslett at silverbackltd.com>
Gerrit-Reviewer: Marshall Dawson <marshall.dawson at se-eng.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-CC: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-CC: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Thu, 13 Sep 2018 02:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180913/57cfc8c5/attachment.html>