<p><a href="https://review.coreboot.org/27619">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/include/amdblocks/psp.h">File src/soc/amd/common/block/include/amdblocks/psp.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/include/amdblocks/psp.h@35">Patch Set #10, Line 35:</a> <code style="font-family:monospace,monospace">#define MAGIC_ENABLE_BITS             0x34 /* Extra PCI HDR Ctl Enables     */ </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">trailing whitespace</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c">File src/soc/amd/common/block/psp/psp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c@49">Patch Set #10, Line 49:</a> <code style="font-family:monospace,monospace">     if (value32 == 0xFFFFFFFF) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">suspect code indent for conditional statements (8, 10)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c@56">Patch Set #10, Line 56:</a> <code style="font-family:monospace,monospace">     if (pci_read_config32(SOC_PSP_DEV, PCI_BASE_ADDRESS_4) & ~0x0F) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">braces {} are not necessary for single statement blocks</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/27619">change 27619</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/27619"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2740ceb945736c6e413f7d0bd0c41a19e19c7d5a </div>
<div style="display:none"> Gerrit-Change-Number: 27619 </div>
<div style="display:none"> Gerrit-PatchSet: 10 </div>
<div style="display:none"> Gerrit-Owner: Charles Marslett <charles.marslett@amd.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Charles Marslett <charles.marslett@amd.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Charles Marslett <charles.marslett@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshall.dawson@se-eng.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-CC: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-CC: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 13 Sep 2018 02:00:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>